Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified search] Create unified search plugin #127651
[Unified search] Create unified search plugin #127651
Changes from 10 commits
65fd06b
9e4a1f2
fde23a5
3733dc0
8e4ae65
469dcb2
cbd4497
bda30d0
a43b85d
de32a7e
12c9f70
edd66f6
11c44df
98e4f68
26104b3
5900a75
d730345
fef0147
3fc8ab1
ca9132d
f8a1a1d
1d111c4
eafd115
258102d
128c372
85e5cae
10e6764
2f5e3fb
a269c5e
57e33cd
dc22e6a
7f180e4
ff08ce0
d422200
f094ecd
5b17156
e423f16
46a8e7e
7d7a3a6
f4ca84b
d9ff6aa
6deb8ae
1a0eeaa
37367f3
3e6d322
4effa45
b7f97cf
72779b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are not moving the FilterBar into the unified plugin and we are using the
esFilters.FilterBar
which is deprecated? This set of components should also be moved into the plugin. It is a part of the unified search and not a part of the data pluginThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our thoughts were to keep the current API for the plugin date, since I see the related code
FilterLabel
FilterItem
lies in theesFilters
object. If @ppisljar ok with moving it out of data plugin too, let's do itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unified plugin should have all the UI components that are part of it and FilterBar is def one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am ok with moving FilterBar out, lets check if FilterLabel and FilterItem are ever imported from esFilters, else they should be removed from there.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.