-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Presentation] Deprecate Solution Toolbar Button in favor of Shared UX Component #126916
Closed
Closed
Changes from 11 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6164988
deprecate
rshen91 a1b8b49
Merge branch 'main' into deprecate-solution-toolbar-button
rshen91 ce333b0
Merge remote-tracking branch 'upstream/main' into deprecate-solution-…
rshen91 5c6cd01
Merge remote-tracking branch 'upstream/main' into deprecate-solution-…
rshen91 cd0b90f
replace the solution toolbar buttons in presentation utils
rshen91 ed176d8
Merge remote-tracking branch 'origin/deprecate-solution-toolbar-butto…
rshen91 997b379
fix imports for storybook to run
rshen91 a75f4b9
Merge branch 'main' into deprecate-solution-toolbar-button
rshen91 c1755c7
fix errors
rshen91 5e4ea0c
Merge remote-tracking branch 'origin/deprecate-solution-toolbar-butto…
rshen91 8959416
update requiredPlugins
rshen91 7054dee
Merge branch 'main' into deprecate-solution-toolbar-button
rshen91 a78e943
props in public
rshen91 a6975c5
Merge remote-tracking branch 'origin/deprecate-solution-toolbar-butto…
rshen91 d565815
fix kibana json
rshen91 6983822
Merge branch 'main' into deprecate-solution-toolbar-button
rshen91 18688d1
clean up
rshen91 0d32c06
Merge branch 'main' into deprecate-solution-toolbar-button
rshen91 52081d2
remove deprecated from public index
rshen91 46c79b0
remove icon side
rshen91 93b5a22
Merge remote-tracking branch 'upstream/main' into deprecate-solution-…
rshen91 e414da2
refactor
rshen91 17d8b8e
change tsconfig
rshen91 d4e7ea9
fix spelling
rshen91 ccdfdb5
remove icon side
rshen91 8678625
Merge branch 'main' into deprecate-solution-toolbar-button
rshen91 49b35eb
Merge remote-tracking branch 'upstream/main' into deprecate-solution-…
rshen91 b60cb4d
Merge remote-tracking branch 'origin/deprecate-solution-toolbar-butto…
rshen91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
src/plugins/presentation_util/public/components/solution_toolbar/items/button.scss
This file was deleted.
Oops, something went wrong.
32 changes: 0 additions & 32 deletions
32
src/plugins/presentation_util/public/components/solution_toolbar/items/button.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
src/plugins/presentation_util/public/components/solution_toolbar/items/primary_button.scss
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
src/plugins/presentation_util/public/components/solution_toolbar/items/primary_button.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For plugin ids we have historically kept to the most simple form of camelcase, and only capitalized the first letter in an abbreviation. Said another way, the capital just replaces the
_
in the snake_case version of the word, soshared_ux
would be comesharedUx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was confused about which PR this is, maybe @clintandrewhall is open to a rename PR outside of this work or maybe when the number of inflight PRs is a bit lower.