Replace role=main by main elements #12671
Conversation
timroes
added
Project:Accessibility
Team:Platform-Design
src/ui/public/styles/base.less
Outdated
| @@ -54,6 +54,10 @@ code { | |||
| word-wrap: break-word; | |||
| } | |||
|
|
|||
| main { | |||
| display: block; | |||
| } | |||
There was a problem hiding this comment.
Can we move this to https://github.com/elastic/kibana/blob/master/ui_framework/components/_common_styles.scss and add a comment?
/**
* 1. Required for IE11.
*/
main {
display: block; /* 1 */
}
|
Jenkins, test this |
| */ | ||
| main { | ||
| display: block; /* 1 */ | ||
| } |
There was a problem hiding this comment.
Oh actually, now that this is part of the UI Framework, we need to recompile and commit the CSS. Just run npm run uiFramework:start to kick off compilation.
There was a problem hiding this comment.
Are you sure, this is still needed? Running the task (or also uiFramework:build doesn't change any files managed by git. Do I need to copy the compiled files somewhere?
There was a problem hiding this comment.
Ah I think I should probably rename that task. npm run uiFramework:start will recompile the compiled CSS, whereas uiFramework:build will only build the documentation site.
There was a problem hiding this comment.
@cjcenizal I ran both of the tasks, none of them touches git managed files for me?
There was a problem hiding this comment.
I created timroes#1 for now. We can walk through the task when you're done with X-School to figure out what's going on. 😄
There was a problem hiding this comment.
Merged, and we figure out next week what's wrong with my buildsystem :D
Add compiled UI Framework CSS.
Replace all
role="main"bymainelements as requested in #12632.Since we support IE11, the
display: blockformainis still needed.Fixes #12632