Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared-ux] Migrate solution toolbar button #125998

Merged
merged 20 commits into from
Mar 3, 2022

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Feb 17, 2022

Summary

Breaking #124372 into smaller PRs.

This PR adds mdx documentation, a storybook example and tests for the primary button within the solution toolbar. This PR is intended to be a starting point for future PRs to build out other solution toolbar components.

The primary button component has been edited to contain the required prop of a label and optional props of onClick and iconType. IconSide has been set to the left based on current implementations.

Current implementations:

  • presentation_utils add from library and popover

Added storybook example:

Screen Shot 2022-02-23 at 10 09 58 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rshen91 rshen91 added backport:skip This commit does not require backporting loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.2.0 labels Feb 17, 2022
@rshen91
Copy link
Contributor Author

rshen91 commented Feb 22, 2022

@elasticmachine merge upstream

@rshen91 rshen91 marked this pull request as ready for review March 3, 2022 15:16
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two minor comments

@rshen91 rshen91 requested a review from majagrubic March 3, 2022 19:52
@clintandrewhall
Copy link
Contributor

Great work!

@clintandrewhall clintandrewhall requested a review from a team March 3, 2022 19:58
@rshen91 rshen91 enabled auto-merge (squash) March 3, 2022 21:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
sharedUX 47 49 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sharedUX 100.5KB 100.8KB +326.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
sharedUX 4.7KB 4.8KB +115.0B
Unknown metric groups

async chunk count

id before after diff
sharedUX 3 4 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rshen91 rshen91 merged commit 9c3c323 into elastic:main Mar 3, 2022
@rshen91 rshen91 deleted the migrate-solution-toolbar-button branch March 4, 2022 14:17
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@rshen91 rshen91 self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants