Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Added features parameter to ES request fetching indices #124163

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Jan 31, 2022

Summary

This PR adds the parameter features when requesting the list of all indices from Elasticsearch that has been exposed by the ES team to improve performance of the Get Index API. This option allows to specify which index properties need to be computed when getting index information: aliases, settings and/or mappings. For Index Management request, we don't need to compute mappings.

Note: Related to #123629 that added filter_path that allows to specify which index properties need to be included in the ES response but even when excluded index properties were still being calculated in ES.

@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 31, 2022
@yuliacech yuliacech requested a review from a team as a code owner January 31, 2022 17:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and works as expected 👍

I also noticed the missing data in the flyout and then saw that we have an issue for it (#123714).

@yuliacech
Copy link
Contributor Author

Thank you, @sebelga!

@yuliacech yuliacech added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 2, 2022
@yuliacech yuliacech merged commit 7b9901e into elastic:main Feb 2, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 2, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 124163

Questions ?

Please refer to the Backport tool documentation

@yuliacech yuliacech deleted the add_features_indices_list branch March 7, 2022 13:31
@lucabelluccini
Copy link
Contributor

Actual version released is 8.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants