-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose 'features' option in Get Index API #83083
Expose 'features' option in Get Index API #83083
Conversation
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @danhermann, I've created a changelog YAML for you. |
Pinging @elastic/clients-team (Team:Clients) |
Pinging @elastic/platform-deployment-management for the new option on this API. 🙂 |
@elasticmachine update branch |
@elasticmachine update branch |
--- | ||
"Should return only selected features": | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the addition of this test did not require specifying a skip version for BWC reasons because GetIndexRequest
already supported this feature. It was just not exposed at the REST layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand why skip version section is not needed here.
When this yaml test is ran against a 7.17 node then this now will fail here,
because it doesn't know the features
query string parameter?
I think whether the features
field is available on the action request isn't relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, note that this test did pass in the BWC test suite below with a 7.17.0 node, though it is quite possible that I misunderstood how it passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the test hit a 8.1.0-SNAPSHOT node during this test run and not a 7.17.0 node?
I would expect this test to fail in a mixed version cluster. Maybe not every time, but at least sometimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe re-run bwc job with test-full-bwc
label attached to this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @martijnvg. That explains it. I'll add the skip version to the test to fix that.
@elasticmachine run elasticsearch-ci/bwc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks, @martijnvg! |
* upstream/master: [DOCS] Switch xrefs to external links (elastic#83590) [DOCS] 'features' flag added in elastic#83083 (elastic#83452) Rename ChangePolicyforIndexIT to ChangePolicyForIndexIT (elastic#83569) Fixing random_sampler tests (elastic#83549) Upgrade Checkstyle to 9.3 (elastic#83314) Make improvements to the release notes generator (elastic#83525) Cleanup DataTierAllocationDecider (elastic#83572) Upgrade jANSI dependency to 2.4.0 (elastic#83566) Speed up Name Collision Check in Metadata.Builder (elastic#83340) SQL: Add range checks to interval multiplication operation (elastic#83478) Remove DiscoveryNodes#getAllNodes (elastic#83538) Make RoutingNodes behave like a collection (elastic#83540) Remove Unused CS Listener from SecurityServerTransportInterceptor (elastic#83556)
Resolves #82948