Removes misc unused so/server/es config deprecations #113173
Conversation
TinaHeiligers
added
release_note:skip
|
@lukeelmers is removing already unused settings from deprecations a breaking change? If so, do we want to add individual breaking changes release notes or bundle them all up on one? I've added a release-note skip as a placeholder for now. |
It is, because users who have been ignoring the deprecation warnings will now no longer be able to start Kibana without removing the unused setting.
No strong preference, but since there are several of them I would probably lean toward consolidating into one list? |
TinaHeiligers
added
release_note:breaking
and removed
release_note:skip
It didn't even cross my mind that folks would ignore a deprecation warning 😆 . |
|
@elasticmachine merge upstream |
mshustov
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
TinaHeiligers
deleted the
config-breaking/remove-deprecated-configs-misc
branch
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Related to #103915
During the 7 series, we added deprecations for configs that were unused to warn folks that setting these would have no effect.
To prepare for the first release of the next major version, we shouldn't be supporting any carried over deprecations and can remove the unused settings.
This PR removes the following 4 unused configurations:
savedObjects.indexCheckTimeout, unusedserver.xsrf.token, unusedelasticsearch.preserveHost, deprecated as unusedelasticsearch.startupTimeout, deprecated as unusedTo reviewers
I couldn't find any other reference to these settings in the docs or tests, hence the tiny PR. If I've missed something, please shout!
Release note
Removes support for
savedObjects.indexCheckTimeout,server.xsrf.token,elasticsearch.preserveHostandelasticsearch.startupTimeoutconfiguration settings.Configuring any of these settings will prevent Kibana from starting up.