Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Analyze Data button if no dashboard access #106020

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Hide Analyze Data button if no dashboard access #106020

merged 3 commits into from
Jul 19, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Jul 16, 2021

Fixes #105476.

@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 16, 2021
@smith smith requested a review from a team as a code owner July 16, 2021 19:56
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

cauemarcondes
cauemarcondes approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smith
Copy link
Contributor Author

smith commented Jul 18, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +200.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit c0528f2 into elastic:master Jul 19, 2021
@smith smith deleted the nls/hide-lens branch July 19, 2021 13:21
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2021
@smith @kibanamachine
Hide Analyze Data button if no dashboard access (elastic#106020)
88049de 
Fixes elastic#105476.
@kibanamachine kibanamachine mentioned this pull request Jul 19, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2021
@smith @kibanamachine
Hide Analyze Data button if no dashboard access (elastic#106020)
4e813b2 
Fixes elastic#105476.
@kibanamachine kibanamachine mentioned this pull request Jul 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 19, 2021
@kibanamachine @smith
Hide Analyze Data button if no dashboard access (#106020) (#106095)
f6782ad 
Fixes #105476.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 19, 2021
@kibanamachine @smith
Hide Analyze Data button if no dashboard access (#106020) (#106094)
7256f7a 
Fixes #105476.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Hide analyze data link when user has no lens permissions
5 participants
@smith @elasticmachine @kibanamachine @dgieselaar @cauemarcondes