Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrations V2] Unskip migration_7.7.2_xpack_100k #103435

Merged
merged 7 commits into from
Jun 29, 2021
Merged

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jun 28, 2021

Flaky Runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1687/

Findings:

The main error I was encountering is with the configs which is not related to the original flakiness issue.

 FAIL  src/core/server/saved_objects/migrationsv2/integration_tests/migration_7.7.2_xpack_100k.test.ts (297.903 s)
11:45:52  
11:45:52  
11:45:52    ● Test suite failed to run
11:45:52  
11:45:52      TypeError: Cannot read property 'append' of undefined
11:45:52  
11:45:52        52 |
11:45:52        53 |     for (const appender of this.appenders) {
11:45:52      > 54 |       appender.append(record);
11:45:52           |                ^
11:45:52        55 |     }
11:45:52        56 |   }
11:45:52        57 |
11:45:52  
11:45:52        at BaseLogger.log (src/core/server/logging/logger.ts:54:16)
11:45:52        at BaseLogger.info (src/core/server/logging/logger.ts:33:10)
11:45:52        at LoggerAdapter.info (src/core/server/logging/logger_adapter.ts:36:17)
11:45:52        at LevelLogger.info (x-pack/plugins/reporting/server/lib/level_logger.ts:58:26)
11:45:52        at backgroundInstall (x-pack/plugins/reporting/server/browsers/install.ts:50:12)

Original issue causing the error

TypeError: this.licenseService.stop is not a function
...

The main issue seems to be resolved here: #97144

The monitoring plugin now checks for this.licenseService.stop before calling the function so this flakiness should no longer happen.

I've ran the test 300 times (locally + via flaky test runner) so far and it seems that the issue is no longer occuring.

Closes #96895

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 28, 2021
@Bamieh Bamieh requested a review from a team as a code owner June 28, 2021 06:55
@Bamieh Bamieh marked this pull request as draft June 28, 2021 06:57
@Bamieh Bamieh marked this pull request as ready for review June 28, 2021 12:23
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 6e308a2 into master Jun 29, 2021
@Bamieh Bamieh deleted the migrations/fix_test branch June 29, 2021 10:28
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 29, 2021
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
3 participants