-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Remove reference tooltip in Formula panel when the popup is open #103283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested but LGTM, this was annoying me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now verified that this works as expected.
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…en (elastic#103283) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
I've noticed that the formula reference tooltip keeps on animate as long as the whole popup is in focus, in particular when scrolling the documentation in it.
I've then extended the
TooltipWrapper
component and used to prevent the tooltip to appear completely when the popover is open: the information in the tooltip is already shown as popover title.Before:
After:
Checklist
Delete any items that are not applicable to this PR.
For maintainers