Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Remove reference tooltip in Formula panel when the popup is open #103283

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jun 24, 2021

Summary

I've noticed that the formula reference tooltip keeps on animate as long as the whole popup is in focus, in particular when scrolling the documentation in it.

I've then extended the TooltipWrapper component and used to prevent the tooltip to appear completely when the popover is open: the information in the tooltip is already shown as popover title.

Before:

formula_tooltip_before

After:

formula_tooltip_after

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 24, 2021
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but LGTM, this was annoying me too.

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now verified that this works as expected.

@wylieconlon wylieconlon marked this pull request as ready for review June 28, 2021 15:45
@wylieconlon wylieconlon requested a review from a team June 28, 2021 15:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +335.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 5c87807 into elastic:master Jun 29, 2021
@dej611 dej611 deleted the fix/formula-tooltip-blink branch June 29, 2021 08:47
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2021
…en (elastic#103283)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 29, 2021
…en (#103283) (#103624)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants