Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signal and abort controller to agent metadata and TakeAction button #103217

Conversation

academo
Copy link
Contributor

@academo academo commented Jun 24, 2021

Summary

Adds a signal and abort controller to get agent metadata and the TakeAction button to prevent network requests stalling and showing a disabled button when switching between different events in the host's events list.

@academo academo changed the title Add signal and abort controller to agent metadata and take an action button Add signal and abort controller to agent metadata and TakeAction button Jun 24, 2021
@academo academo added auto-backport Deprecated - use backport:version if exact versions are needed v7.14.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 28, 2021
@academo academo marked this pull request as ready for review June 28, 2021 07:46
@academo academo requested a review from a team as a code owner June 28, 2021 07:46
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.2MB 6.2MB +142.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might need someone from the detections team to look at this as well.

@academo academo added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Jun 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Thanks

@academo academo merged commit ac17ab1 into elastic:master Jun 29, 2021
@academo academo deleted the fix/abort_agent_metadata_request_take_action-1335 branch June 29, 2021 06:58
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 29, 2021
…on (#103217) (#103611)

Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants