Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Duplicated EMS instructions for Elastic Cloud #103124

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Jun 23, 2021

This is a small addition to the EMS tutorial so it sends also instructions for Elastic Cloud users.

There is also a small fix for the EMS Landing Page URL rendering since the self-hosted version needs a trailing / character. This works also fine in the default cloud URL.

Fixes: #95482

@jsanz jsanz added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.13.3 labels Jun 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing
code review

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, thx for fixing the url-gen

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jsanz jsanz changed the title Duplicated EMS instructions for Elastic Cloud [Maps] Duplicated EMS instructions for Elastic Cloud Jun 23, 2021
@jsanz jsanz merged commit 1813d70 into elastic:master Jun 23, 2021
@jsanz jsanz deleted the ems-instructions-cloud branch June 23, 2021 19:12
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Jorge Sanz <jorge.sanz@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Jorge Sanz <jorge.sanz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.13.3 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps][Add data] Cannot open EMS Boundaries card
5 participants