Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas] Reduce bundle size by co-locating strings with components #103013

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[canvas] Reduce bundle size by co-locating strings with components #103013

merged 1 commit into from
Jun 23, 2021

Conversation

clintandrewhall
Copy link
Contributor

Summary

Moving component portions of the Canvas i18n dictionary to their individual components offloaded 60k from the page bundle to async bundles. I also audited and removed old string functions that hadn't been removed.

This change should be fairly passive, as I just moved functions around.

Before on left, after on right.

Screen Shot 2021-06-22 at 3 55 30 PM

Screen Shot 2021-06-22 at 3 58 39 PM

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas v7.14.0 labels Jun 22, 2021
@clintandrewhall clintandrewhall requested a review from a team as a code owner June 22, 2021 21:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/secure_roles_perm·js.security app secure roles and permissions should add new user

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: security app
[00:00:00]           └-> "before all" hook in "security app"
[00:04:04]           └-: secure roles and permissions
[00:04:04]             └-> "before all" hook for "should add new role logstash_reader"
[00:04:04]             └-> "before all" hook for "should add new role logstash_reader"
[00:04:04]               │ debg users
[00:04:04]               │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "mappings.json"
[00:04:04]               │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "data.json.gz"
[00:04:04]               │ info [x-pack/test/functional/es_archives/logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:04:04]               │ info [x-pack/test/functional/es_archives/logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:04:04]               │ info [x-pack/test/functional/es_archives/logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:04:05]               │ debg load kibana index with default index pattern
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Loading "mappings.json"
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Loading "data.json.gz"
[00:04:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_001/YDfEUkGvQi2VHmEFhC1V1g] deleting index
[00:04:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_task_manager_8.0.0_001/ht5FOGMfT5ecaF8rGUiJBQ] deleting index
[00:04:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_1/s7W3tiytQ72WhkJXFIY-EA] deleting index
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Deleted existing index ".kibana_8.0.0_001"
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Deleted existing index ".kibana_1"
[00:04:05]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Created index ".kibana_1"
[00:04:05]               │ debg [x-pack/test/functional/es_archives/security/discover] ".kibana_1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:04:05]               │ info [x-pack/test/functional/es_archives/security/discover] Indexed 3 docs into ".kibana"
[00:04:05]               │ debg Migrating saved objects
[00:04:05]               │ proc [kibana]   log   [21:32:03.910] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 7ms.
[00:04:05]               │ proc [kibana]   log   [21:32:03.915] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 14ms.
[00:04:05]               │ proc [kibana]   log   [21:32:03.919] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> SET_SOURCE_WRITE_BLOCK. took: 4ms.
[00:04:05]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:05]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:04:05]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] adding block write to indices [[.kibana_1/z_1mqsRpRLaRmhx3Xd7Hhw]]
[00:04:05]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] completed adding block write to indices [.kibana_1]
[00:04:05]               │ proc [kibana]   log   [21:32:04.001] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 91ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.017] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP. took: 98ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.040] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 39ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.041] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 138ms
[00:04:05]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:04:05]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:04:05]               │ proc [kibana]   log   [21:32:04.107] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 90ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.113] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 6ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.127] [info][savedobjects-service] [.kibana] Starting to process 3 documents.
[00:04:05]               │ proc [kibana]   log   [21:32:04.127] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_INDEX. took: 13ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.135] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 9ms.
[00:04:05]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_reindex_temp/HHc81yrqSaq07qD-R0q7Iw] update_mapping [_doc]
[00:04:05]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_reindex_temp/HHc81yrqSaq07qD-R0q7Iw] update_mapping [_doc]
[00:04:05]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_reindex_temp/HHc81yrqSaq07qD-R0q7Iw] update_mapping [_doc]
[00:04:05]               │ proc [kibana]   log   [21:32:04.245] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 110ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.254] [info][savedobjects-service] [.kibana] Processed 3 documents out of 3.
[00:04:05]               │ proc [kibana]   log   [21:32:04.255] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 9ms.
[00:04:05]               │ proc [kibana]   log   [21:32:04.260] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 5ms.
[00:04:05]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] adding block write to indices [[.kibana_8.0.0_reindex_temp/HHc81yrqSaq07qD-R0q7Iw]]
[00:04:05]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:04:06]               │ proc [kibana]   log   [21:32:04.307] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 48ms.
[00:04:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:04:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:04:06]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:04:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_001/UnGCDl-eR6OXW9yI-tSEiw] create_mapping
[00:04:06]               │ proc [kibana]   log   [21:32:04.441] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 134ms.
[00:04:06]               │ proc [kibana]   log   [21:32:04.445] [info][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 4ms.
[00:04:06]               │ proc [kibana]   log   [21:32:04.448] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 3ms.
[00:04:06]               │ proc [kibana]   log   [21:32:04.459] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 11ms.
[00:04:06]               │ proc [kibana]   log   [21:32:04.463] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 4ms.
[00:04:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_001/UnGCDl-eR6OXW9yI-tSEiw] update_mapping [_doc]
[00:04:06]               │ proc [kibana]   log   [21:32:04.529] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 66ms.
[00:04:06]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] 10397 finished with response BulkByScrollResponse[took=28.1ms,timed_out=false,sliceId=null,updated=3,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:06]               │ proc [kibana]   log   [21:32:04.635] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 106ms.
[00:04:06]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_reindex_temp/HHc81yrqSaq07qD-R0q7Iw] deleting index
[00:04:06]               │ proc [kibana]   log   [21:32:04.675] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 40ms.
[00:04:06]               │ proc [kibana]   log   [21:32:04.676] [info][savedobjects-service] [.kibana] Migration completed after 775ms
[00:04:06]               │ debg [x-pack/test/functional/es_archives/security/discover] Migrated Kibana index after loading Kibana data
[00:04:06]               │ debg [x-pack/test/functional/es_archives/security/discover] Ensured that default space exists in .kibana
[00:04:06]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:04:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_8.0.0_001/UnGCDl-eR6OXW9yI-tSEiw] update_mapping [_doc]
[00:04:08]               │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:04:09]               │ debg navigating to settings url: http://localhost:61221/app/management
[00:04:09]               │ debg navigate to: http://localhost:61221/app/management
[00:04:09]               │ debg browser[INFO] http://localhost:61221/app/management?_t=1624397527400 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:09]               │
[00:04:09]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:09]               │ debg ... sleep(700) start
[00:04:09]               │ debg ... sleep(700) end
[00:04:09]               │ debg returned from get, calling refresh
[00:04:11]               │ERROR browser[SEVERE] http://localhost:61221/43740/bundles/core/core.entry.js 12:153128 TypeError: Failed to fetch
[00:04:11]               │          at fetch_Fetch.fetchResponse (http://localhost:61221/43740/bundles/core/core.entry.js:6:26193)
[00:04:11]               │          at async http://localhost:61221/43740/bundles/core/core.entry.js:6:24090
[00:04:11]               │          at async http://localhost:61221/43740/bundles/core/core.entry.js:6:23996
[00:04:11]               │ debg browser[INFO] http://localhost:61221/app/management?_t=1624397527400 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:11]               │
[00:04:11]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:11]               │ debg currentUrl = http://localhost:61221/app/management
[00:04:11]               │          appUrl = http://localhost:61221/app/management
[00:04:11]               │ debg TestSubjects.find(kibanaChrome)
[00:04:11]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:12]               │ debg ... sleep(501) start
[00:04:12]               │ debg ... sleep(501) end
[00:04:12]               │ debg in navigateTo url = http://localhost:61221/app/management
[00:04:12]             └-> should add new role logstash_reader
[00:04:12]               └-> "before each" hook: global before each for "should add new role logstash_reader"
[00:04:12]               │ debg navigating to settings url: http://localhost:61221/app/management
[00:04:12]               │ debg navigate to: http://localhost:61221/app/management
[00:04:13]               │ debg browser[INFO] http://localhost:61221/app/management?_t=1624397530868 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:13]               │
[00:04:13]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:13]               │ debg ... sleep(700) start
[00:04:13]               │ debg ... sleep(700) end
[00:04:13]               │ debg returned from get, calling refresh
[00:04:15]               │ debg browser[INFO] http://localhost:61221/app/management?_t=1624397530868 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:15]               │
[00:04:15]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:15]               │ debg currentUrl = http://localhost:61221/app/management
[00:04:15]               │          appUrl = http://localhost:61221/app/management
[00:04:15]               │ debg TestSubjects.find(kibanaChrome)
[00:04:15]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:15]               │ debg ... sleep(501) start
[00:04:16]               │ debg ... sleep(501) end
[00:04:16]               │ debg in navigateTo url = http://localhost:61221/app/management
[00:04:16]               │ debg TestSubjects.click(roles)
[00:04:16]               │ debg Find.clickByCssSelector('[data-test-subj="roles"]') with timeout=10000
[00:04:16]               │ debg Find.findByCssSelector('[data-test-subj="roles"]') with timeout=10000
[00:04:16]               │ debg TestSubjects.click(createRoleButton)
[00:04:16]               │ debg Find.clickByCssSelector('[data-test-subj="createRoleButton"]') with timeout=10000
[00:04:16]               │ debg Find.findByCssSelector('[data-test-subj="createRoleButton"]') with timeout=10000
[00:04:16]               │ debg roleObj.indices[0].names = logstash-*
[00:04:16]               │ debg TestSubjects.append(roleFormNameInput, logstash_reader)
[00:04:16]               │ debg TestSubjects.find(roleFormNameInput)
[00:04:16]               │ debg Find.findByCssSelector('[data-test-subj="roleFormNameInput"]') with timeout=10000
[00:04:16]               │ debg comboBox.setCustom, comboBoxSelector: indicesInput0, value: logstash-*
[00:04:16]               │ debg TestSubjects.find(indicesInput0)
[00:04:16]               │ debg Find.findByCssSelector('[data-test-subj="indicesInput0"]') with timeout=10000
[00:04:19]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:04:19]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:04:19]               │ debg TestSubjects.click(addSpacePrivilegeButton)
[00:04:19]               │ debg Find.clickByCssSelector('[data-test-subj="addSpacePrivilegeButton"]') with timeout=10000
[00:04:19]               │ debg Find.findByCssSelector('[data-test-subj="addSpacePrivilegeButton"]') with timeout=10000
[00:04:19]               │ debg TestSubjects.click(spaceSelectorComboBox)
[00:04:19]               │ debg Find.clickByCssSelector('[data-test-subj="spaceSelectorComboBox"]') with timeout=10000
[00:04:19]               │ debg Find.findByCssSelector('[data-test-subj="spaceSelectorComboBox"]') with timeout=10000
[00:04:19]               │ debg Find.findByCssSelector('#spaceOption_\*') with timeout=10000
[00:04:20]               │ debg TestSubjects.click(basePrivilege_all)
[00:04:20]               │ debg Find.clickByCssSelector('[data-test-subj="basePrivilege_all"]') with timeout=10000
[00:04:20]               │ debg Find.findByCssSelector('[data-test-subj="basePrivilege_all"]') with timeout=10000
[00:04:20]               │ debg TestSubjects.click(createSpacePrivilegeButton)
[00:04:20]               │ debg Find.clickByCssSelector('[data-test-subj="createSpacePrivilegeButton"]') with timeout=10000
[00:04:20]               │ debg Find.findByCssSelector('[data-test-subj="createSpacePrivilegeButton"]') with timeout=10000
[00:04:20]               │ debg Adding privilege read to role
[00:04:20]               │ debg Find.findByCssSelector('[data-test-subj="privilegesInput0"] input') with timeout=10000
[00:04:20]               │ debg Find.byButtonText('read') with timeout=10000
[00:04:21]               │ debg ... sleep(250) start
[00:04:21]               │ debg ... sleep(250) end
[00:04:21]               │ debg Adding privilege view_index_metadata to role
[00:04:21]               │ debg Find.findByCssSelector('[data-test-subj="privilegesInput0"] input') with timeout=10000
[00:04:21]               │ debg Find.byButtonText('view_index_metadata') with timeout=10000
[00:04:22]               │ debg ... sleep(250) start
[00:04:22]               │ debg ... sleep(250) end
[00:04:22]               │ debg click save button
[00:04:22]               │ debg TestSubjects.click(roleFormSaveButton)
[00:04:22]               │ debg Find.clickByCssSelector('[data-test-subj="roleFormSaveButton"]') with timeout=10000
[00:04:22]               │ debg Find.findByCssSelector('[data-test-subj="roleFormSaveButton"]') with timeout=10000
[00:04:22]               │ debg TestSubjects.exists(roleRow)
[00:04:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="roleRow"]') with timeout=120000
[00:04:22]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] added role [logstash_reader]
[00:04:23]               └- ✓ pass  (10.8s) "security app secure roles and permissions should add new role logstash_reader"
[00:04:23]             └-> should add new user
[00:04:23]               └-> "before each" hook: global before each for "should add new user"
[00:04:23]               │ debg After Add user new: , userObj.userName
[00:04:23]               │ debg navigating to settings url: http://localhost:61221/app/management
[00:04:23]               │ debg navigate to: http://localhost:61221/app/management
[00:04:23]               │ debg browser[INFO] http://localhost:61221/app/management?_t=1624397541657 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:23]               │
[00:04:23]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:23]               │ debg ... sleep(700) start
[00:04:24]               │ debg ... sleep(700) end
[00:04:24]               │ debg returned from get, calling refresh
[00:04:25]               │ debg browser[INFO] http://localhost:61221/app/management?_t=1624397541657 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:25]               │
[00:04:25]               │ debg browser[INFO] http://localhost:61221/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:25]               │ debg currentUrl = http://localhost:61221/app/management
[00:04:25]               │          appUrl = http://localhost:61221/app/management
[00:04:25]               │ debg TestSubjects.find(kibanaChrome)
[00:04:25]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:25]               │ERROR browser[SEVERE] http://localhost:61221/api/licensing/info - Failed to load resource: net::ERR_NETWORK_CHANGED
[00:04:25]               │ERROR browser[SEVERE] http://localhost:61221/api/fleet/epm/packages?experimental=true - Failed to load resource: net::ERR_NETWORK_CHANGED
[00:04:25]               │ERROR browser[SEVERE] http://localhost:61221/internal/global_search/searchable_types - Failed to load resource: net::ERR_NETWORK_CHANGED
[00:04:25]               │ debg browser[INFO] http://localhost:61221/43740/bundles/core/core.entry.js 12:154056 "Detected an unhandled Promise rejection.
[00:04:25]               │      TypeError: Failed to fetch"
[00:04:25]               │ERROR browser[SEVERE] http://localhost:61221/43740/bundles/core/core.entry.js 5:2514 
[00:04:25]               │ debg ... sleep(501) start
[00:04:26]               │ debg ... sleep(501) end
[00:04:26]               │ debg in navigateTo url = http://localhost:61221/app/management
[00:04:26]               │ debg TestSubjects.click(users)
[00:04:26]               │ debg Find.clickByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:04:26]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:04:36]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:04:36]               │      Wait timed out after 10019ms
[00:04:36]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:04:47]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:04:47]               │      Wait timed out after 10035ms
[00:04:47]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:04:52]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1624395810010163203] [.kibana_task_manager_8.0.0_001/6-HQ90tkQMu17bl0vaMmfQ] update_mapping [_doc]
[00:04:57]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:04:57]               │      Wait timed out after 10042ms
[00:04:58]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:05:08]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:05:08]               │      Wait timed out after 10051ms
[00:05:08]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:05:18]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:05:18]               │      Wait timed out after 10049ms
[00:05:19]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:05:29]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:05:29]               │      Wait timed out after 10046ms
[00:05:29]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:05:39]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:05:39]               │      Wait timed out after 10035ms
[00:05:40]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:05:50]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:05:50]               │      Wait timed out after 10043ms
[00:05:50]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:06:00]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:06:00]               │      Wait timed out after 10052ms
[00:06:01]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:06:11]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:06:11]               │      Wait timed out after 10017ms
[00:06:11]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:06:21]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:06:21]               │      Wait timed out after 10037ms
[00:06:22]               │ debg Find.findByCssSelector('[data-test-subj="users"]') with timeout=10000
[00:06:32]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:06:32]               │      Wait timed out after 10010ms
[00:06:32]               │ info Taking screenshot "/dev/shm/workspace/parallel/22/kibana/x-pack/test/functional/screenshots/failure/security app secure roles and permissions should add new user.png"
[00:06:33]               │ info Current URL is: http://localhost:61221/app/management
[00:06:33]               │ info Saving page source to: /dev/shm/workspace/parallel/22/kibana/x-pack/test/functional/failure_debug/html/security app secure roles and permissions should add new user.html
[00:06:33]               └- ✖ fail: security app secure roles and permissions should add new user
[00:06:33]               │      Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="users"])
[00:06:33]               │ Wait timed out after 10010ms
[00:06:33]               │     at /dev/shm/workspace/parallel/22/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:06:33]               │     at runMicrotasks (<anonymous>)
[00:06:33]               │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:06:33]               │       at onFailure (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:06:33]               │       at retryForSuccess (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:06:33]               │       at RetryService.try (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry.ts:31:12)
[00:06:33]               │       at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/22/kibana/test/functional/services/common/find.ts:360:5)
[00:06:33]               │       at TestSubjects.click (/dev/shm/workspace/parallel/22/kibana/test/functional/services/common/test_subjects.ts:105:5)
[00:06:33]               │       at SecurityPageObject.clickUsersSection (test/functional/page_objects/security_page.ts:281:5)
[00:06:33]               │       at SecurityPageObject.clickElasticsearchUsers (test/functional/page_objects/security_page.ts:354:5)
[00:06:33]               │       at SecurityPageObject.createUser (test/functional/page_objects/security_page.ts:449:5)
[00:06:33]               │       at Context.<anonymous> (test/functional/apps/security/secure_roles_perm.js:56:7)
[00:06:33]               │       at Object.apply (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:06:33]               │ 
[00:06:33]               │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="users"])
Wait timed out after 10010ms
    at /dev/shm/workspace/parallel/22/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at onFailure (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at RetryService.try (/dev/shm/workspace/parallel/22/kibana/test/common/services/retry/retry.ts:31:12)
    at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/22/kibana/test/functional/services/common/find.ts:360:5)
    at TestSubjects.click (/dev/shm/workspace/parallel/22/kibana/test/functional/services/common/test_subjects.ts:105:5)
    at SecurityPageObject.clickUsersSection (test/functional/page_objects/security_page.ts:281:5)
    at SecurityPageObject.clickElasticsearchUsers (test/functional/page_objects/security_page.ts:354:5)
    at SecurityPageObject.createUser (test/functional/page_objects/security_page.ts:449:5)
    at Context.<anonymous> (test/functional/apps/security/secure_roles_perm.js:56:7)
    at Object.apply (/dev/shm/workspace/parallel/22/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1115 1114 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.3MB 1.3MB +53.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 521.8KB 463.3KB -58.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611
crob611 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Very nice

@clintandrewhall clintandrewhall added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 23, 2021
@clintandrewhall clintandrewhall merged commit 0669895 into elastic:master Jun 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
@clintandrewhall @kibanamachine
[canvas] Reduce bundle size by co-locating strings with components (e…
7c3a88c 
…lastic#103013)
@kibanamachine kibanamachine mentioned this pull request Jun 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 25, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Jun 30, 2021
@kibanamachine @clintandrewhall
[canvas] Reduce bundle size by co-locating strings with components (#…
f3a2d16 
…103013) (#103183)

Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2021
@clintandrewhall clintandrewhall deleted the canvas/i18n/components branch July 9, 2021 16:27
@clintandrewhall clintandrewhall mentioned this pull request Feb 14, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clintandrewhall @elasticmachine @kibanamachine @crob611