[Security Solution]Memory protection configuration card for policies integration. #101365

academo · 2021-06-04T10:14:13Z

Summary

Adds the Memory Protection configuration card in the policies detail view.

The current implementation is a clone of the malware protection card.

Missing on this PR:

Data migrations for the new "memory" key in policy details
Put this functionality behind a feature flag

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

policies integration.

…on-1213

x-pack/plugins/security_solution/common/endpoint/models/policy_config.ts

parkiino · 2021-06-04T16:47:54Z

checked out the branch! looking good so far :D

…on-1213

elasticmachine · 2021-06-28T08:16:31Z

Pinging @elastic/fleet (Team:Fleet)

…on-1213

jen-huang

Fleet changes for adding the migration LGTM, though I'll let others take a more thorough look into the workings.

x-pack/plugins/security_solution/common/license/policy_config.ts

...k/plugins/security_solution/public/management/pages/policy/view/policy_forms/locked_card.tsx

…on-1213

paul-tavares

A some comment. Let me know if you have any questions

x-pack/plugins/fleet/server/saved_objects/migrations/security_solution/to_v7_15_0.ts

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details_form.tsx

…on-1213

dasansol92 · 2021-07-16T13:04:44Z

[This comment is a test] Testing slack notifications

…on-1213

paul-tavares

Left two comments, but am OK with you proceeding to merge.

...ns/security_solution/public/management/pages/policy/view/policy_forms/protections/memory.tsx

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details_form.tsx

kibanamachine · 2021-07-19T16:42:08Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2208	2209	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.3MB	6.3MB	+3.1KB

History

💚 Build #139368 succeeded bca703e
💚 Build #139278 succeeded ef13baf
💚 Build #139046 succeeded 162ba9c
💚 Build #138357 succeeded 4c294e2
💚 Build #137747 succeeded 578489a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…integration. (elastic#101365)

kibanamachine · 2021-07-19T16:44:49Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…y-show-migrate-to-authzd-users * 'master' of github.com:elastic/kibana: (187 commits) Space management page UX improvements (elastic#100448) [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252) Update dependency @elastic/charts to v33 (master) (elastic#105633) [Observability RAC] Improve alerts table columns (elastic#105446) Introduce `preboot` lifecycle stage (elastic#103636) [Security Solution] Invalid kql query timeline refresh bug (elastic#105525) skip flaky suite (elastic#106121) [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118) docs: APM RUM Source map API (elastic#105332) [CTI] Adds indicator match rule improvements (elastic#97310) [Security Solution] update text for Isolation action submissions (elastic#105956) EP Meta Telemetry Perf (elastic#104396) [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784) Remove beta admonitions for Fleet docs (elastic#106010) [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970) Parameterize migration test for kibana version (elastic#105417) [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626) [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007) [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027) [Security Solution]Memory protection configuration card for policies integration. (elastic#101365) ... # Conflicts: # x-pack/plugins/reporting/public/management/report_listing.test.tsx # x-pack/plugins/reporting/public/management/report_listing.tsx

…integration. (#101365) (#106129) Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>

academo added 2 commits June 3, 2021 17:42

Initial implementation of the memory protection configuration card for

247edf8

policies integration.

Fix and add tests for memory integration policy details card

8d109bf

academo added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 labels Jun 4, 2021

academo requested review from parkiino and paul-tavares June 4, 2021 10:14

academo added 3 commits June 4, 2021 13:26

Merge branch 'master' into feature/memory_protection_policy_integrati…

1eb2ea1

…on-1213

Change the default notification message for memory protection

3f2e077

Updated locked card messages for locked protections

1cca66f

parkiino reviewed Jun 4, 2021

View reviewed changes

x-pack/plugins/security_solution/common/endpoint/models/policy_config.ts Outdated Show resolved Hide resolved

academo added 17 commits June 7, 2021 10:31

Cover gold and basic licence cases

350ee16

Update tests to support the new types

2245fd4

Fix translations validator problems

61b1f05

Update unit tests to represent rendered data

7221139

Fix types

2e769a0

Add minimium agent requirement for memory protection

5954204

Merge branch 'master' into feature/memory_protection_policy_integrati…

390f8bb

…on-1213

Fix broken unit test for non-platinum license

08c4d2e

Merge branch 'master' into feature/memory_protection_policy_integrati…

bedfe6b

…on-1213

Add data migration for memory protection in 7.15

9dfab66

Add data migration export to index.ts file

31d5dd4

Add v7.15 migration to the saved_objects def file

7b1930c

Merge branch 'master' into feature/memory_protection_policy_integrati…

07b6ef7

…on-1213

Merge branch 'master' into feature/memory_protection_policy_integrati…

3641e93

…on-1213

Merge branch 'master' into feature/memory_protection_policy_integrati…

2842c6b

…on-1213

Change memory by memory_protection in memory_protection card

75c3730

Add missing license upgrade/downgrade testing and changes

076f94a

academo marked this pull request as ready for review June 28, 2021 07:12

academo requested a review from a team as a code owner June 28, 2021 07:12

academo added the release_note:feature Makes this part of the condensed release notes label Jun 28, 2021

academo changed the title ~~Memory protection configuration card for policies integration.~~ [Security Solution]Memory protection configuration card for policies integration. Jun 29, 2021

Merge branch 'master' into feature/memory_protection_policy_integrati…

08d6c41

…on-1213

jen-huang approved these changes Jun 30, 2021

View reviewed changes

jen-huang added the v8.0.0 label Jun 30, 2021

dasansol92 reviewed Jul 1, 2021

View reviewed changes

x-pack/plugins/security_solution/common/license/policy_config.ts Outdated Show resolved Hide resolved

...k/plugins/security_solution/public/management/pages/policy/view/policy_forms/locked_card.tsx Outdated Show resolved Hide resolved

academo added 2 commits July 1, 2021 12:56

Remove duplicated condition

72817cd

Merge branch 'master' into feature/memory_protection_policy_integrati…

f6c7902

…on-1213

academo added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 1, 2021

Remove unintented file

884ab6e

paul-tavares reviewed Jul 1, 2021

View reviewed changes

x-pack/plugins/fleet/server/saved_objects/migrations/security_solution/to_v7_15_0.ts Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details_form.tsx Outdated Show resolved Hide resolved

academo added 4 commits July 12, 2021 09:29

Merge branch 'master' into feature/memory_protection_policy_integrati…

7f2dfc8

…on-1213

Migration early exit if key not found

578489a

Merge branch 'master' into feature/memory_protection_policy_integrati…

4c294e2

…on-1213

Merge branch 'master' into feature/memory_protection_policy_integrati…

162ba9c

…on-1213

academo requested a review from a team as a code owner July 16, 2021 13:03

academo added 2 commits July 19, 2021 09:25

Merge branch 'master' into feature/memory_protection_policy_integrati…

ef13baf

…on-1213

Merge branch 'master' into feature/memory_protection_policy_integrati…

bca703e

…on-1213

paul-tavares approved these changes Jul 19, 2021

View reviewed changes

...ns/security_solution/public/management/pages/policy/view/policy_forms/protections/memory.tsx Show resolved Hide resolved

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details_form.tsx Outdated Show resolved Hide resolved

Use i18 translations instead of JSX components

de1e0c5

academo enabled auto-merge (squash) July 19, 2021 14:42

academo merged commit ebc0274 into elastic:master Jul 19, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 19, 2021

[Security Solution]Memory protection configuration card for policies …

b059acd

…integration. (elastic#101365)

kibanamachine mentioned this pull request Jul 19, 2021

[7.x] [Security Solution]Memory protection configuration card for policies integration. (#101365) #106129

Merged

kibanamachine added a commit that referenced this pull request Jul 20, 2021

[Security Solution]Memory protection configuration card for policies …

74e944e

…integration. (#101365) (#106129) Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution]Memory protection configuration card for policies integration. #101365

[Security Solution]Memory protection configuration card for policies integration. #101365

academo commented Jun 4, 2021 •

edited

Loading

parkiino commented Jun 4, 2021

elasticmachine commented Jun 28, 2021

jen-huang left a comment

paul-tavares left a comment

dasansol92 commented Jul 16, 2021

paul-tavares left a comment

kibanamachine commented Jul 19, 2021

kibanamachine commented Jul 19, 2021

[Security Solution]Memory protection configuration card for policies integration. #101365

[Security Solution]Memory protection configuration card for policies integration. #101365

Conversation

academo commented Jun 4, 2021 • edited Loading

Summary

Missing on this PR:

Checklist

For maintainers

parkiino commented Jun 4, 2021

elasticmachine commented Jun 28, 2021

jen-huang left a comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

dasansol92 commented Jul 16, 2021

paul-tavares left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Jul 19, 2021

💚 Backport successful

academo commented Jun 4, 2021 •

edited

Loading