Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB offsets #40299

Closed
kobelb opened this issue Jul 3, 2019 · 2 comments · Fixed by #83051
Closed

TSVB offsets #40299

kobelb opened this issue Jul 3, 2019 · 2 comments · Fixed by #83051
Assignees
@VladLasitsa
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kobelb
Copy link
Contributor

kobelb commented Jul 3, 2019 •
edited
Loading

The change made in #34283 has unintended side-effects for month and year offsets.

Focusing on months, we're now always adding "30 days" to the original date because moment.duration(offsetValue, offsetUnit).valueOf() is always 30 days in duration. This causes us to transform "2019-05-01" to "2019-05-31" instead of "2019-06-01" like we used to.

Originally reported here: https://discuss.elastic.co/t/different-behavior-kibana-visual-builder-7-2-0-vs-7-1-1/188655
@kobelb kobelb added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes
Copy link
Contributor

timroes commented Jul 4, 2019

cc @alexwizp @Avinar-24

@VladLasitsa VladLasitsa self-assigned this Sep 14, 2020
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 10, 2020
@alexwizp
TSVB offsets
cad925f 
Closes: elastic#40299
@alexwizp alexwizp mentioned this issue Nov 10, 2020
Merged
2 tasks
kibanamachine added a commit to alexwizp/kibana that referenced this issue Nov 11, 2020
@kibanamachine
Merge branch 'master' into elastic#40299
27d6370
kibanamachine added a commit to alexwizp/kibana that referenced this issue Nov 17, 2020
@kibanamachine
Merge branch 'master' into elastic#40299
bf6fe68
kibanamachine added a commit to alexwizp/kibana that referenced this issue Nov 25, 2020
@kibanamachine
Merge branch 'master' into elastic#40299
01719d2
alexwizp added a commit that referenced this issue Nov 26, 2020
@alexwizp @kibanamachine
TSVB offsets (#83051)
93b0273 
Closes: #40299

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2020
@alexwizp @kibanamachine
TSVB offsets (elastic#83051)
a8354fb 
Closes: elastic#40299

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit that referenced this issue Nov 26, 2020
@alexwizp @kibanamachine
TSVB offsets (#83051) (#84421)
0cbba91 
Closes: #40299

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stratoula stratoula mentioned this issue Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladLasitsa VladLasitsa

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] offset option doesn't work properly for some values alexwizp/kibana
4 participants
@kobelb @timroes @elasticmachine @VladLasitsa