-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spaces] Enable Per-Space Advanced Settings #19869
Comments
When editing advanced settings, we need to be able to visually differentiate between space-aware and non-space-aware options. For example, we need to make it abundantly clear that changing Additionally, this needs to be done in a way that allows the Advanced Settings UI to remain ignorant of the Spaces plugin. Do you have any initial thoughts on how we could accomplish this? Jen, I tagged you since you did the Reactification of the settings screen, so I thought you might have some insight that I'm lacking |
@legrego, we probably want to discuss with @elastic/kibana-design to figure out the best way to represent this and disclose to the user that the advanced settings are "space specific" and let that drive our implementation. I doubt there's anything architecturally in place right now that will afford us this capability and we'll have to add some extension points. |
Right off the bat, I would say that space-aware settings and kibana-wide settings should not live in the same list. Even if you surround the kibana-wide settings in some alert, the user should know before-hand if they are going to be modifying just the current space's settings or all spaces. We may want to discuss how this might affect the management index page and the best way to disclose this type of information. |
@cchaos how would you feel about "tabs" at the top to separate between the two "sections"? |
@kobelb I worry that tabs aren't enough to signify the severe differences between the two. |
@cchaos are you alluding to you thinking that we need two separate "pages"? |
@kobelb I am alluding. :) Right now we've got this idea of hierarchy: But with spaces, I would expect that space management (including space-specific settings) would be under |
For anyone following this issue, we have changed our approach. Rather than having a few exceptions to the space-aware settings, we are instead revising our implementation so that we do not have any exceptions to the space-aware rule. Specifically:
|
Each Space within Kibana should have its own set of Advanced Settings. It's possible that not all settings will translate properly, so I'm creating this issue to track research and findings as we go.
NOTE Our approach has changed. See this comment for more information
Space Aware
/ cc @kobelb
The text was updated successfully, but these errors were encountered: