Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/dashboard/group3/dashboard_state·ts - dashboard app - group 3 dashboard state Directly modifying url updates dashboard state when removing a panel #183752

Closed
kibanamachine opened this issue May 17, 2024 · 1 comment · Fixed by #183643
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/dashboard/group3/dashboard_state·ts - dashboard app - group 3 dashboard state Directly modifying url updates dashboard state when removing a panel #183752

kibanamachine opened this issue May 17, 2024 · 1 comment · Fixed by #183643
Assignees
@rshen91
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: Unable to locate query parameters in URL: http://localhost:5620/app/r/s/sCQXi
    at updateAppStateQueryParam (dashboard_state.ts:51:13)
    at Context.<anonymous> (dashboard_state.ts:270:24)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:73:16)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label May 17, 2024
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label May 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 17, 2024
This was referenced May 21, 2024
Closed
Merged
saikatsarkar056 pushed a commit to saikatsarkar056/kibana that referenced this issue Jun 13, 2024
@rshen91 @saikatsarkar056
[Fix] Additional tests and clean up for share modal redesign initiati…
e4c3c59 
…ve (elastic#183643)

## Summary

Closes elastic#181066
Closes epic elastic/kibana-team#735
Closes elastic#183752

- [x] Based on PR elastic#180406, the
test 'generates a report with single timefilter' was skipped in
x-pack/test/functional/apps/discover/reporting.ts because short URLs are
the default and make the test fail.
- [x] In addition test/functional/apps/dashboard/group5/share.ts was
skipped for similar reasons
- [x] x-pack/test/functional/apps/lens/group4/share.ts 'should preserve
filter and query when sharing'
- [x]
[x-pack/test_serverless/functional/test_suites/common/discover/x_pack/reporting.ts](https://github.com/elastic/kibana/pull/180406/files/03f8d94aedd6d76bcaf7cfa4db714c7665269807#diff-f8df59654e26e509d3e2b9fd3b998da7ea0f7b1d02bddced1acbd588d6b55883)
refactoring
- [x]
[x-pack/test/functional/apps/discover/feature_controls/discover_security.ts](https://github.com/elastic/kibana/pull/180406/files/ec0bec8387e8b75de2e57adb34517741052e18c4#diff-1efa1c849e2a1f9e206702cafa82c5d5d7b1a446add207b693f8fbebc992b59d)
- [x] Add lens by-value FTR to confirm share link in lens is passing a
share link that will open to a Lens visualization. For reference check
out
elastic#180406 (review)


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Additional tests and clean up for share modal redesign initiative rshen91/kibana
3 participants
@elasticmachine @rshen91 @kibanamachine