[Test refactoring] Short Urls by default leading to removing or skipped tests #181066
Assignees
Labels
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Team:DataDiscovery
Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
Comments
3 tasks
mbondyra
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
I don't think these tests are owned by Fleet, so I'm removing the team label. If I've misunderstood please feel free to add it back. |
kpollich
removed
the
Team:Fleet
rshen91
added
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
davismcphee
added
the
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Heenawter
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
Adding the Presentation tag so that we can more easily keep an eye on this 🙇 |
rshen91
added a commit
that referenced
this issue
May 15, 2024
## Summary This PR makes the share redesign modal work the primary share context paradigm (excluding Canvas) by removing the share plugin config that had share.new_version.enabled for testing and implementation. This PR cleans up the FTRs. Closes [#151523](#151523) As a result of defaulting to short urls, some tests were removed since they are now obsolete. One fix in this PR to avoid customer known issues is to allow reporting (if license is permitted) for watcher users. Refer to elastic/sdh-kibana#4481 (comment). I've opened a separate issue to track any skipped or deleted tests as a result of short urls by default here #181066 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) ### Release Note The share menu is updated for a more streamlined user experience. Users can navigate through a tabbed modal to copy links for discover, dashboard, and lens. --------- Co-authored-by: Eyo Okon Eyo <eyo.eyo@elastic.co> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
8 tasks
kertal
added
the
impact:high
saikatsarkar056
pushed a commit
to saikatsarkar056/kibana
that referenced
this issue
Jun 13, 2024
…ve (elastic#183643) ## Summary Closes elastic#181066 Closes epic elastic/kibana-team#735 Closes elastic#183752 - [x] Based on PR elastic#180406, the test 'generates a report with single timefilter' was skipped in x-pack/test/functional/apps/discover/reporting.ts because short URLs are the default and make the test fail. - [x] In addition test/functional/apps/dashboard/group5/share.ts was skipped for similar reasons - [x] x-pack/test/functional/apps/lens/group4/share.ts 'should preserve filter and query when sharing' - [x] [x-pack/test_serverless/functional/test_suites/common/discover/x_pack/reporting.ts](https://github.com/elastic/kibana/pull/180406/files/03f8d94aedd6d76bcaf7cfa4db714c7665269807#diff-f8df59654e26e509d3e2b9fd3b998da7ea0f7b1d02bddced1acbd588d6b55883) refactoring - [x] [x-pack/test/functional/apps/discover/feature_controls/discover_security.ts](https://github.com/elastic/kibana/pull/180406/files/ec0bec8387e8b75de2e57adb34517741052e18c4#diff-1efa1c849e2a1f9e206702cafa82c5d5d7b1a446add207b693f8fbebc992b59d) - [x] Add lens by-value FTR to confirm share link in lens is passing a share link that will open to a Lens visualization. For reference check out elastic#180406 (review) ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
'generates a report with single timefilter'was skipped inx-pack/test/functional/apps/discover/reporting.tsbecause short URLs are the default and make the test fail.test/functional/apps/dashboard/group5/share.tswas deleted for similar reasons'should preserve filter and query when sharing'This issue is opened to track the refactoring of this specific test in order to merge #180406 and not block the feature release.
The text was updated successfully, but these errors were encountered: