Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] [Guided onboarding] Open issues #144458

Closed
4 of 6 tasks
osmanis opened this issue Nov 2, 2022 · 6 comments
Closed
4 of 6 tasks

[Meta] [Guided onboarding] Open issues #144458

osmanis opened this issue Nov 2, 2022 · 6 comments
Labels
Team:Journey/Onboarding Platform Journey Onboarding team

Comments

@osmanis
Copy link

osmanis commented Nov 2, 2022

This is a list of open issues related to guided onboarding for 8.6.

SIEM Guide

Kubernetes Guide

Search Guide

TBD

@alisonelizabeth @yuliacech

@osmanis osmanis added the Team:Journey/Onboarding Platform Journey Onboarding team label Nov 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Nov 2, 2022

Thanks for the feedback @osmanis!

The tour for Elastic Defend does not show

This has not be implemented yet. Should be addressed with #143917

On the Elastic Defend integration page, the tour has a Next button. I think this should say Okay instead since there's no other tour step here.

I think this concern came up before (#142185 (comment) ), and we decided "Next" was appropriate. @kellyemurphy can you take a look again and weigh in here?


@stephmilovic @xcrzx can you both take a look at the feedback regarding the alert/rules tours? Thanks!

@kellyemurphy
Copy link
Contributor

Instead of "Okay", how about we go with "Got it"?

@xcrzx
Copy link
Contributor

xcrzx commented Nov 9, 2022

The Rule tour keeps showing even after searching for my first rule.

@osmanis Not sure I understand what you mean. What would be the expected behavior?

It also has two steps showing and there's no Okay button. I think we should remove the step icons and have an Okay button to dismiss it.

We've agreed previously with @gavinwye that there should be only two steps and no Okay button. Could you please align on that before I make any changes?

@gavinwye, Have you had a chance to review the guided onboarding implementation in the rules area? It would be awesome to collect all feedback in one place.

@gavinwye
Copy link

gavinwye commented Nov 11, 2022

We're adding a "Next" button (as originally designed) to the rules selection pages.

This Next button will filter the table to show the rule. Clicking next will advance to another tour component that will point to the rule toggle to enable it.

I've collated all my feedback in this Figjam file https://www.figma.com/file/TxPRM8hdV4xPjDuf6OEFBp/Guided-onboarding-feedback-v2?node-id=0%3A1

There are some differences in the content of the tour that's in main from what was designed by @kellyemurphy.
Tour in main
image
Content as designed
image

xcrzx added a commit that referenced this issue Nov 15, 2022
…area (#145223)

**Related to: #144016

## Summary

This follow-up PR addresses guided onboarding feedback mentioned
[here](elastic/security-team#5386) and
[here](#144458).

To summarize:

- We're keeping the first step (install prebuilt rules) intact, but most
users wouldn't see it as the rules are installed automatically during
previous stages. This step is needed to cover edge cases when rules were
deleted for some reason.
- We're splitting the second step into two: 1) search the first rule and
2) activate it.
- We're adding "Next" buttons to these steps.
- For the search step, the "Next" button will automatically filter the
rules table, so the first rule becomes visible.
- For the activate step, the "Next" button automatically activates the
first rule.
- The "Next" button stays optional; we still automatically progress the
guide once user actions satisfy certain conditions, like the user
filtered the rules table manually or activated the first rule by
clicking its toggle.
benakansara pushed a commit to benakansara/kibana that referenced this issue Nov 17, 2022
…area (elastic#145223)

**Related to: elastic#144016

## Summary

This follow-up PR addresses guided onboarding feedback mentioned
[here](elastic/security-team#5386) and
[here](elastic#144458).

To summarize:

- We're keeping the first step (install prebuilt rules) intact, but most
users wouldn't see it as the rules are installed automatically during
previous stages. This step is needed to cover edge cases when rules were
deleted for some reason.
- We're splitting the second step into two: 1) search the first rule and
2) activate it.
- We're adding "Next" buttons to these steps.
- For the search step, the "Next" button will automatically filter the
rules table, so the first rule becomes visible.
- For the activate step, the "Next" button automatically activates the
first rule.
- The "Next" button stays optional; we still automatically progress the
guide once user actions satisfy certain conditions, like the user
filtered the rules table manually or activated the first rule by
clicking its toggle.
@alisonelizabeth
Copy link
Contributor

I believe all the feedback has been addressed here. Feel free to open up separate issues if you find anything outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Journey/Onboarding Platform Journey Onboarding team
Projects
None yet
Development

No branches or pull requests

6 participants