Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Spaces Selector to a new KibanaPageTemplate component #140274

Closed
azasypkin opened this issue Sep 8, 2022 · 1 comment · Fixed by #148655
Closed

Migrate Spaces Selector to a new KibanaPageTemplate component #140274

azasypkin opened this issue Sep 8, 2022 · 1 comment · Fixed by #148655
Labels
chore Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@azasypkin
Copy link
Member

Summary

According to #139524 (comment) we need to migrated Spaces Selector to a new KibanaPageTemplate component (provided by @kbn/shared-ux-page-kibana-template).

The deprecated KibanaPageTemplate we rely on right now will be removed by August 2023.
@azasypkin azasypkin added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature labels Sep 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@thomheymann thomheymann mentioned this issue Jan 10, 2023
Merged
thomheymann added a commit that referenced this issue Jan 11, 2023
@thomheymann @kibanamachine
Migrate Spaces Selector to a new KibanaPageTemplate component (#148655)
d2788bc 
Resolves #140274

## Summary

Migrate Spaces Selector to a new `KibanaPageTemplate` component

<img width="1298" alt="Screenshot 2023-01-10 at 16 26 45"
src="https://user-images.githubusercontent.com/190132/211610410-b744d9e0-0a71-4564-aefa-23472c26c516.png">

## Testing

1. Create at least 1 additional space
2. Go to Kibana root path http://localhost:5601/ and observe space
selector screen being rendered correctly

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jennypavlova pushed a commit to jennypavlova/kibana that referenced this issue Jan 13, 2023
@thomheymann @kibanamachine @jennypavlova
Migrate Spaces Selector to a new KibanaPageTemplate component (elasti…
86c621b 
…c#148655)

Resolves elastic#140274

## Summary

Migrate Spaces Selector to a new `KibanaPageTemplate` component

<img width="1298" alt="Screenshot 2023-01-10 at 16 26 45"
src="https://user-images.githubusercontent.com/190132/211610410-b744d9e0-0a71-4564-aefa-23472c26c516.png">

## Testing

1. Create at least 1 additional space
2. Go to Kibana root path http://localhost:5601/ and observe space
selector screen being rendered correctly

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate Spaces Selector to a new KibanaPageTemplate component thomheymann/kibana
2 participants
@azasypkin @elasticmachine