Resolved type error within EuiContextMenu by removing the watchedItem…

…Props prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed
elastic · May 18, 2022 · f8a3e2e · f8a3e2e
1 parent bd52b5b
commit f8a3e2e
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 13 deletions.
diff --git a/x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/saved_objects_finder.tsx b/x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/saved_objects_finder.tsx
@@ -394,10 +394,7 @@ export class SavedObjectFinderUi extends React.Component<
                   </EuiFilterButton>
                 }
               >
-                <EuiContextMenuPanel
-                  watchedItemProps={['icon', 'disabled']}
-                  items={this.getSortOptions()}
-                />
+                <EuiContextMenuPanel items={this.getSortOptions()} />
               </EuiPopover>
               {this.props.showFilter && (
                 <EuiPopover
@@ -430,7 +427,6 @@ export class SavedObjectFinderUi extends React.Component<
                   }
                 >
                   <EuiContextMenuPanel
-                    watchedItemProps={['icon', 'disabled']}
                     items={this.props.savedObjectMetaData.map((metaData) => (
                       <EuiContextMenuItem
                         key={metaData.type}

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/datapanel.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/datapanel.tsx
@@ -671,7 +671,6 @@ export const InnerIndexPatternDataPanel = function InnerIndexPatternDataPanel({
               }
             >
               <EuiContextMenuPanel
-                watchedItemProps={['icon', 'disabled']}
                 data-test-subj="lnsIndexPatternTypeFilterOptions"
                 items={(availableFieldTypes as DataType[]).map((type) => (
                   <EuiContextMenuItem

diff --git a/x-pack/plugins/ml/public/application/components/anomalies_table/links_menu.tsx b/x-pack/plugins/ml/public/application/components/anomalies_table/links_menu.tsx
@@ -694,11 +694,7 @@ export const LinksMenuUI = (props: LinksMenuProps) => {
   ]);
 
   return (
-    <EuiContextMenuPanel
-      items={contextMenuItems}
-      watchedItemProps={['disabled', 'href']} // Ensures the 'View in Discover' link rerenders when loading completes
-      data-test-subj="mlAnomaliesListRowActionsMenu"
-    />
+    <EuiContextMenuPanel items={contextMenuItems} data-test-subj="mlAnomaliesListRowActionsMenu" />
   );
 };
 

diff --git a/...ns/security/public/management/roles/edit_role/spaces_popover_list/spaces_popover_list.tsx b/...ns/security/public/management/roles/edit_role/spaces_popover_list/spaces_popover_list.tsx
@@ -73,7 +73,6 @@ export class SpacesPopoverList extends Component<Props, State> {
       title: i18n.translate('xpack.security.management.editRole.spacesPopoverList.popoverTitle', {
         defaultMessage: 'Spaces',
       }),
-      watchedItemProps: ['data-search-term'],
     };
 
     if (this.props.spaces.length >= SPACE_SEARCH_COUNT_THRESHOLD) {

diff --git a/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx b/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx
@@ -69,7 +69,6 @@ class SpacesMenuUI extends Component<Props, State> {
         id: 'xpack.spaces.navControl.spacesMenu.changeCurrentSpaceTitle',
         defaultMessage: 'Change current space',
       }),
-      watchedItemProps: ['data-search-term'],
     };
 
     if (this.props.spaces.length >= SPACE_SEARCH_COUNT_THRESHOLD) {