Skip to content

Commit

Permalink
Fix merge conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
sulemanof committed Sep 24, 2020
1 parent 3f4bb43 commit e5a8f23
Showing 1 changed file with 10 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import React from 'react';
import { wait } from '@testing-library/dom';
import { render, cleanup } from '@testing-library/react/pure';
import { MarkdownVisWrapper } from './markdown_vis_controller';
import MarkdownVisComponent from './markdown_vis_controller';

afterEach(cleanup);

Expand All @@ -36,7 +36,7 @@ describe('markdown vis controller', () => {
};

const { getByTestId, getByText } = render(
<MarkdownVisWrapper visParams={vis.params} renderComplete={jest.fn()} fireEvent={jest.fn()} />
<MarkdownVisComponent {...vis.params} renderComplete={jest.fn()} />
);

await wait(() => getByTestId('markdownBody'));
Expand All @@ -60,7 +60,7 @@ describe('markdown vis controller', () => {
};

const { getByTestId, getByText } = render(
<MarkdownVisWrapper visParams={vis.params} renderComplete={jest.fn()} fireEvent={jest.fn()} />
<MarkdownVisComponent {...vis.params} renderComplete={jest.fn()} />
);

await wait(() => getByTestId('markdownBody'));
Expand All @@ -82,17 +82,15 @@ describe('markdown vis controller', () => {
};

const { getByTestId, getByText, rerender } = render(
<MarkdownVisWrapper visParams={vis.params} renderComplete={jest.fn()} fireEvent={jest.fn()} />
<MarkdownVisComponent {...vis.params} renderComplete={jest.fn()} />
);

await wait(() => getByTestId('markdownBody'));

expect(getByText(/initial/i)).toBeInTheDocument();

vis.params.markdown = 'Updated';
rerender(
<MarkdownVisWrapper visParams={vis.params} renderComplete={jest.fn()} fireEvent={jest.fn()} />
);
rerender(<MarkdownVisComponent {...vis.params} renderComplete={jest.fn()} />);

expect(getByText(/Updated/i)).toBeInTheDocument();
});
Expand All @@ -114,11 +112,7 @@ describe('markdown vis controller', () => {

it('should be called on initial rendering', async () => {
const { getByTestId } = render(
<MarkdownVisWrapper
visParams={vis.params}
renderComplete={renderComplete}
fireEvent={jest.fn()}
/>
<MarkdownVisComponent {...vis.params} renderComplete={renderComplete} />
);

await wait(() => getByTestId('markdownBody'));
Expand All @@ -128,11 +122,7 @@ describe('markdown vis controller', () => {

it('should be called on successive render when params change', async () => {
const { getByTestId, rerender } = render(
<MarkdownVisWrapper
visParams={vis.params}
renderComplete={renderComplete}
fireEvent={jest.fn()}
/>
<MarkdownVisComponent {...vis.params} renderComplete={renderComplete} />
);

await wait(() => getByTestId('markdownBody'));
Expand All @@ -142,24 +132,14 @@ describe('markdown vis controller', () => {
renderComplete.mockClear();
vis.params.markdown = 'changed';

rerender(
<MarkdownVisWrapper
visParams={vis.params}
renderComplete={renderComplete}
fireEvent={jest.fn()}
/>
);
rerender(<MarkdownVisComponent {...vis.params} renderComplete={renderComplete} />);

expect(renderComplete).toHaveBeenCalledTimes(1);
});

it('should be called on successive render even without data change', async () => {
const { getByTestId, rerender } = render(
<MarkdownVisWrapper
visParams={vis.params}
renderComplete={renderComplete}
fireEvent={jest.fn()}
/>
<MarkdownVisComponent {...vis.params} renderComplete={renderComplete} />
);

await wait(() => getByTestId('markdownBody'));
Expand All @@ -168,13 +148,7 @@ describe('markdown vis controller', () => {

renderComplete.mockClear();

rerender(
<MarkdownVisWrapper
visParams={vis.params}
renderComplete={renderComplete}
fireEvent={jest.fn()}
/>
);
rerender(<MarkdownVisComponent {...vis.params} renderComplete={renderComplete} />);

expect(renderComplete).toHaveBeenCalledTimes(1);
});
Expand Down

0 comments on commit e5a8f23

Please sign in to comment.