Fix failing test

elastic · Dec 20, 2022 · cb1970a · cb1970a
1 parent 971c936
commit cb1970a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/actions/server/actions_config.ts b/x-pack/plugins/actions/server/actions_config.ts
@@ -209,9 +209,9 @@ export function getActionsConfigurationUtilities(
       );
 
       return (
-        connectorTypeConfig?.maxAttempts ??
-        config.run?.maxAttempts ??
-        actionTypeMaxAttempts ??
+        connectorTypeConfig?.maxAttempts ||
+        config.run?.maxAttempts ||
+        actionTypeMaxAttempts ||
         DEFAULT_MAX_ATTEMPTS
       );
     },

diff --git a/x-pack/plugins/actions/server/lib/task_runner_factory.ts b/x-pack/plugins/actions/server/lib/task_runner_factory.ts
@@ -105,7 +105,7 @@ export class TaskRunnerFactory {
         // Throwing an executor error means we will attempt to retry the task
         // TM will treat a task as a failure if `attempts >= maxAttempts`
         // so we need to handle that here to avoid TM persisting the failed task
-        const isRetryableBasedOnAttempts = taskInfo.attempts < (maxAttempts ?? 1);
+        const isRetryableBasedOnAttempts = taskInfo.attempts < maxAttempts;
         const willRetryMessage = `and will retry`;
         const willNotRetryMessage = `and will not retry`;