do not assign required if array is empty

elastic · Aug 9, 2024 · b776259 · b776259
1 parent 06bc1a3
commit b776259
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...ispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.test.ts b/...ispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.test.ts
@@ -11,13 +11,10 @@ import { joi2JsonInternal } from '../../parse';
 import { processObject } from './object';
 
 test.each([
-  [
-    schema.object({}),
-    { type: 'object', properties: {}, additionalProperties: false, required: [] },
-  ],
+  [schema.object({}), { type: 'object', properties: {}, additionalProperties: false }],
   [
     schema.object({ never: schema.never() }),
-    { type: 'object', properties: {}, additionalProperties: false, required: [] },
+    { type: 'object', properties: {}, additionalProperties: false },
   ],
   [
     schema.object(

diff --git a/...penapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.ts b/...penapispec/src/oas_converter/kbn_config_schema/post_process_mutations/mutations/object.ts
@@ -38,7 +38,7 @@ const populateRequiredFields = (schema: OpenAPIV3.SchemaObject): void => {
     }
   }
 
-  schema.required = required;
+  if (required.length > 0) schema.required = required;
 };
 
 const removeNeverType = (schema: OpenAPIV3.SchemaObject): void => {