[Lens] Fix label input debouncing (#84121) (#84315)

elastic · Nov 25, 2020 · 9ecb412 · 9ecb412
1 parent 73c3964
commit 9ecb412
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx
@@ -6,7 +6,7 @@
 
 import './dimension_editor.scss';
 import _ from 'lodash';
-import React, { useState, useMemo, useEffect } from 'react';
+import React, { useState, useMemo } from 'react';
 import { i18n } from '@kbn/i18n';
 import {
   EuiListGroup,
@@ -46,10 +46,6 @@ export interface DimensionEditorProps extends IndexPatternDimensionEditorProps {
 const LabelInput = ({ value, onChange }: { value: string; onChange: (value: string) => void }) => {
   const [inputValue, setInputValue] = useState(value);
 
-  useEffect(() => {
-    setInputValue(value);
-  }, [value, setInputValue]);
-
   const onChangeDebounced = useMemo(() => _.debounce(onChange, 256), [onChange]);
 
   const handleInputChange = (e: React.ChangeEvent<HTMLInputElement>) => {

diff --git a/...ins/lens/public/indexpattern_datasource/operations/definitions/filters/filter_popover.tsx b/...ins/lens/public/indexpattern_datasource/operations/definitions/filters/filter_popover.tsx
@@ -110,10 +110,6 @@ export const QueryInput = ({
 }) => {
   const [inputValue, setInputValue] = useState(value);
 
-  React.useEffect(() => {
-    setInputValue(value);
-  }, [value, setInputValue]);
-
   useDebounce(() => onChange(inputValue), 256, [inputValue]);
 
   const handleInputChange = (input: Query) => {

diff --git a/...s/public/indexpattern_datasource/operations/definitions/shared_components/label_input.tsx b/...s/public/indexpattern_datasource/operations/definitions/shared_components/label_input.tsx
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import React, { useState, useEffect } from 'react';
+import React, { useState } from 'react';
 import useDebounce from 'react-use/lib/useDebounce';
 import { EuiFieldText, keys } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
@@ -28,10 +28,6 @@ export const LabelInput = ({
 }) => {
   const [inputValue, setInputValue] = useState(value);
 
-  useEffect(() => {
-    setInputValue(value);
-  }, [value, setInputValue]);
-
   useDebounce(() => onChange(inputValue), 256, [inputValue]);
 
   const handleInputChange = (e: React.ChangeEvent<HTMLInputElement>) => {