Skip to content

Commit

Permalink
🔥 Remove temporary externalUrl workaround
Browse files Browse the repository at this point in the history
- set in 9d993d8

- WorkplaceSearchHeaderActions should now still have the correct URL - and also now be able to access all Kea logic set up by the main app :)
  • Loading branch information
cee-chen committed Sep 28, 2020
1 parent 791d537 commit 9a855bd
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions x-pack/plugins/enterprise_search/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
WORKPLACE_SEARCH_PLUGIN,
} from '../common/constants';
import { IInitialAppData } from '../common/types';
import { externalUrl } from './applications/shared/enterprise_search_url';

export interface ClientConfigType {
host?: string;
Expand Down Expand Up @@ -168,10 +167,6 @@ export class EnterpriseSearchPlugin implements Plugin {
try {
this.data = await http.get('/api/enterprise_search/config_data');
this.hasInitialized = true;

// TODO: This is a temporary workaround to keep the WorkplaceSearchHeaderActions working.
// We'll solve this shortly by ensuring the main app store loads before the header actions.
externalUrl.enterpriseSearchUrl = this.data.publicUrl || this.config.host;
} catch {
this.data.errorConnecting = true;
}
Expand Down

0 comments on commit 9a855bd

Please sign in to comment.