Added suggestions from code review

elastic · Jul 19, 2021 · 972a2f9 · 972a2f9
1 parent 21168e7
commit 972a2f9
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 7 deletions.
diff --git a/.../public/management/edit_space/customize_space/__snapshots__/customize_space.test.tsx.snap b/.../public/management/edit_space/customize_space/__snapshots__/customize_space.test.tsx.snap
diff --git a/x-pack/plugins/spaces/public/management/edit_space/customize_space/customize_space.tsx b/x-pack/plugins/spaces/public/management/edit_space/customize_space/customize_space.tsx
@@ -10,6 +10,7 @@ import {
   EuiFieldText,
   EuiFormRow,
   EuiLoadingSpinner,
+  EuiText,
   EuiTextArea,
   EuiTitle,
 } from '@elastic/eui';
@@ -102,9 +103,14 @@ export class CustomizeSpace extends Component<Props, State> {
                 defaultMessage: 'Description',
               }
             )}
-            labelAppend={i18n.translate('xpack.spaces.management.manageSpacePage.optionalLabel', {
-              defaultMessage: 'Optional',
-            })}
+            labelAppend={
+              <EuiText color="subdued" size="xs">
+                <FormattedMessage
+                  id="xpack.spaces.management.manageSpacePage.optionalLabel"
+                  defaultMessage="Optional"
+                />
+              </EuiText>
+            }
             helpText={i18n.translate(
               'xpack.spaces.management.manageSpacePage.spaceDescriptionHelpText',
               {
@@ -176,7 +182,7 @@ export class CustomizeSpace extends Component<Props, State> {
                   <LazySpaceAvatar
                     space={{
                       ...space,
-                      initials: undefined,
+                      initials: '?',
                       name: undefined,
                     }}
                     size="xl"

diff --git a/...ck/plugins/spaces/public/management/edit_space/customize_space/customize_space_avatar.tsx b/...ck/plugins/spaces/public/management/edit_space/customize_space/customize_space_avatar.tsx
@@ -29,7 +29,7 @@ interface Props {
 }
 
 export class CustomizeSpaceAvatar extends Component<Props> {
-  private storeImageChanges(imageUrl: string) {
+  private storeImageChanges(imageUrl: string | undefined) {
     this.props.onChange({
       ...this.props.space,
       imageUrl,
@@ -80,7 +80,10 @@ export class CustomizeSpaceAvatar extends Component<Props> {
   };
 
   private onFileUpload = (files: FileList | null) => {
-    if (files == null) return;
+    if (files == null || files.length === 0) {
+      this.storeImageChanges(undefined);
+      return;
+    }
     const file = files[0];
     if (imageTypes.indexOf(file.type) > -1) {
       encode(file).then((dataurl: string) => this.handleImageUpload(dataurl));