Rename subactions

elastic · Aug 30, 2020 · 904c152 · 904c152
1 parent 90bc2fc
commit 904c152
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 23 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/jira/index.ts b/x-pack/plugins/actions/server/builtin_action_types/jira/index.ts
@@ -119,15 +119,15 @@ async function executor(
     logger.debug(`response push to service for incident id: ${data.id}`);
   }
 
-  if (subAction === 'getIssueTypes') {
+  if (subAction === 'issueTypes') {
     const getIssueTypesParams = subActionParams as ExecutorSubActionGetIssueTypesParams;
     data = await api.getIssueTypes({
       externalService,
       params: getIssueTypesParams,
     });
   }
 
-  if (subAction === 'getFieldsByIssueType') {
+  if (subAction === 'fieldsByIssueType') {
     const getFieldsByIssueTypeParams = subActionParams as ExecutorSubActionGetFieldsByIssueTypeParams;
     data = await api.getFieldsByIssueType({
       externalService,

diff --git a/x-pack/plugins/actions/server/builtin_action_types/jira/schema.ts b/x-pack/plugins/actions/server/builtin_action_types/jira/schema.ts
@@ -74,11 +74,11 @@ export const ExecutorParamsSchema = schema.oneOf([
     subActionParams: ExecutorSubActionPushParamsSchema,
   }),
   schema.object({
-    subAction: schema.literal('getIssueTypes'),
+    subAction: schema.literal('issueTypes'),
     subActionParams: ExecutorSubActionGetIssueTypesParamsSchema,
   }),
   schema.object({
-    subAction: schema.literal('getFieldsByIssueType'),
+    subAction: schema.literal('fieldsByIssueType'),
     subActionParams: ExecutorSubActionGetFieldsByIssueTypeParamsSchema,
   }),
 ]);
diff --git a/...lugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/api.ts b/...lugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/api.ts
@@ -7,23 +7,6 @@
 import { HttpSetup } from 'kibana/public';
 import { BASE_ACTION_API_PATH } from '../../../constants';
 
-export async function getCreateIssueMetadata({
-  http,
-  signal,
-  connectorId,
-}: {
-  http: HttpSetup;
-  signal: AbortSignal;
-  connectorId: string;
-}): Promise<Record<string, any>> {
-  return await http.post(`${BASE_ACTION_API_PATH}/action/${connectorId}/_execute`, {
-    body: JSON.stringify({
-      params: { subAction: 'getCreateIssueMetadata', subActionParams: {} },
-    }),
-    signal,
-  });
-}
-
 export async function getIssueTypes({
   http,
   signal,
@@ -35,7 +18,7 @@ export async function getIssueTypes({
 }): Promise<Record<string, any>> {
   return await http.post(`${BASE_ACTION_API_PATH}/action/${connectorId}/_execute`, {
     body: JSON.stringify({
-      params: { subAction: 'getIssueTypes', subActionParams: {} },
+      params: { subAction: 'issueTypes', subActionParams: {} },
     }),
     signal,
   });
@@ -54,7 +37,7 @@ export async function getFieldsByIssueType({
 }): Promise<Record<string, any>> {
   return await http.post(`${BASE_ACTION_API_PATH}/action/${connectorId}/_execute`, {
     body: JSON.stringify({
-      params: { subAction: 'getFieldsByIssueType', subActionParams: { id } },
+      params: { subAction: 'fieldsByIssueType', subActionParams: { id } },
     }),
     signal,
   });