Skip to content

Commit

Permalink
update breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
nickofthyme committed Jul 16, 2021
1 parent 720d90e commit 66f4bac
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 11 deletions.
5 changes: 3 additions & 2 deletions src/plugins/vis_type_xy/public/utils/render_all_series.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
Accessor,
AccessorFn,
ColorVariant,
LabelOverflowConstraint,
} from '@elastic/charts';

import { DatatableRow } from '../../../expressions/public';
Expand Down Expand Up @@ -130,7 +131,7 @@ export const renderAllSeries = (
minBarHeight={2}
displayValueSettings={{
showValueLabel,
hideClippedValue: true,
overflowConstraints: [LabelOverflowConstraint.ChartEdges],
}}
/>
);
Expand Down Expand Up @@ -161,7 +162,7 @@ export const renderAllSeries = (
stackAccessors={isStacked ? ['__any_value__'] : undefined}
displayValueSettings={{
showValueLabel,
hideClippedValue: true,
overflowConstraints: [LabelOverflowConstraint.ChartEdges],
}}
timeZone={timeZone}
stackMode={stackMode}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion x-pack/plugins/lens/public/xy_visualization/expression.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
ElementClickListener,
BrushEndListener,
CurveType,
LabelOverflowConstraint,
} from '@elastic/charts';
import { I18nProvider } from '@kbn/i18n/react';
import {
Expand Down Expand Up @@ -909,7 +910,7 @@ export function XYChart({
showValueLabel: shouldShowValueLabels && valueLabels !== 'hide',
isAlternatingValueLabel: false,
isValueContainedInElement: true,
hideClippedValue: true,
overflowConstraints: [LabelOverflowConstraint.ChartEdges],
},
};
return <BarSeries key={index} {...seriesProps} {...valueLabelsSettings} />;
Expand Down

0 comments on commit 66f4bac

Please sign in to comment.