removed restriction to set remote_elasticsearch data output on agent …

…policy with apm
elastic · Dec 14, 2023 · 6178650 · 6178650
1 parent efa5a6a
commit 6178650
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 15 deletions.
diff --git a/x-pack/plugins/fleet/common/services/output_helpers.test.ts b/x-pack/plugins/fleet/common/services/output_helpers.test.ts
@@ -26,7 +26,7 @@ describe('getAllowedOutputTypeForPolicy', () => {
     expect(res).toContain('logstash');
   });
 
-  it('should return only elasticsearch for an agent policy with APM', () => {
+  it('should return only elasticsearch types for an agent policy with APM', () => {
     const res = getAllowedOutputTypeForPolicy({
       package_policies: [
         {
@@ -35,7 +35,7 @@ describe('getAllowedOutputTypeForPolicy', () => {
       ],
     } as any);
 
-    expect(res).toEqual(['elasticsearch']);
+    expect(res).toEqual(['elasticsearch', 'remote_elasticsearch']);
   });
 
   it('should return only elasticsearch for an agent policy with Fleet Server', () => {

diff --git a/x-pack/plugins/fleet/common/services/output_helpers.ts b/x-pack/plugins/fleet/common/services/output_helpers.ts
@@ -28,15 +28,21 @@ export function getAllowedOutputTypeForPolicy(agentPolicy: AgentPolicy) {
     agentPolicy.package_policies &&
     agentPolicy.package_policies.some(
       (p) =>
-        p.package?.name === FLEET_APM_PACKAGE ||
-        p.package?.name === FLEET_SERVER_PACKAGE ||
-        p.package?.name === FLEET_SYNTHETICS_PACKAGE
+        p.package?.name === FLEET_SERVER_PACKAGE || p.package?.name === FLEET_SYNTHETICS_PACKAGE
     );
 
   if (isRestrictedToSameClusterES) {
     return [outputType.Elasticsearch];
   }
 
+  const isRestrictedToESType =
+    agentPolicy.package_policies &&
+    agentPolicy.package_policies.some((p) => p.package?.name === FLEET_APM_PACKAGE);
+
+  if (isRestrictedToESType) {
+    return [outputType.Elasticsearch, outputType.RemoteElasticsearch];
+  }
+
   return Object.values(outputType);
 }
 

diff --git a/...ations/fleet/sections/agent_policy/components/agent_policy_advanced_fields/hooks.test.tsx b/...ations/fleet/sections/agent_policy/components/agent_policy_advanced_fields/hooks.test.tsx
@@ -155,7 +155,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {
@@ -182,7 +182,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {
@@ -209,7 +209,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {
@@ -283,7 +283,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {
@@ -310,7 +310,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {
@@ -337,7 +337,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {
@@ -466,7 +466,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisableOutputTypeText"
                 values={
                   Object {
@@ -498,7 +498,7 @@ describe('useOutputOptions', () => {
               size="s"
             >
               <FormattedMessage
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
                 values={
                   Object {

diff --git a/...pplications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/hooks.tsx b/...pplications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/hooks.tsx
@@ -90,7 +90,7 @@ export function useOutputOptions(agentPolicy: Partial<NewAgentPolicy | AgentPoli
     const defaultOutputDisabledMessage = defaultOutputDisabled ? (
       <FormattedMessage
         id="xpack.fleet.agentPolicyForm.outputOptionDisableOutputTypeText"
-        defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+        defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
         values={{
           outputType: defaultOutput.type,
         }}
@@ -109,7 +109,7 @@ export function useOutputOptions(agentPolicy: Partial<NewAgentPolicy | AgentPoli
             isOutputTypeUnsupported ? (
               <FormattedMessage
                 id="xpack.fleet.agentPolicyForm.outputOptionDisabledTypeNotSupportedText"
-                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics or APM."
+                defaultMessage="{outputType} output for agent integration is not supported for Fleet Server, Synthetics. APM is only supported for elasticsearch types."
                 values={{
                   outputType: item.type,
                 }}