Apply suggestions from code review

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
elastic · Dec 3, 2020 · 59f001d · 59f001d
1 parent 724bb27
commit 59f001d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/...rch/public/applications/app_search/components/documents/document_creation_button.test.tsx b/...rch/public/applications/app_search/components/documents/document_creation_button.test.tsx
@@ -3,6 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
 import { setMockActions } from '../../../__mocks__/kea.mock';
 
 import React from 'react';

diff --git a/...arch/public/applications/app_search/components/documents/search_experience/hooks.test.tsx b/...arch/public/applications/app_search/components/documents/search_experience/hooks.test.tsx
@@ -3,6 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
 const mockAction = jest.fn();
 
 let mockSubcription: (state: object) => void;

diff --git a/...lic/applications/app_search/components/documents/search_experience/search_experience.scss b/...lic/applications/app_search/components/documents/search_experience/search_experience.scss
@@ -6,7 +6,7 @@
 
   .documentsSearchExperience__sidebar {
     flex-grow: 1;
-    min-width: 300px;
+    min-width: $euiSize * 19;
   }
 
   .documentsSearchExperience__content {
@@ -17,5 +17,3 @@
     flex-grow: 0;
   }
 }
-
-
diff --git a/...ions/app_search/components/documents/search_experience/search_experience_content.test.tsx b/...ions/app_search/components/documents/search_experience/search_experience_content.test.tsx
@@ -37,7 +37,7 @@ describe('SearchExperienceContent', () => {
 
   it('renders', () => {
     const wrapper = shallow(<SearchExperienceContent />);
-    expect(wrapper.find(EuiFlexGroup).length).toBe(1);
+     expect(wrapper.isEmptyRender()).toBe(false);
   });
 
   it('passes engineName to the result view', () => {
@@ -69,7 +69,7 @@ describe('SearchExperienceContent', () => {
     expect(wrapper.isEmptyRender()).toBe(true);
   });
 
-  it('renders results if a search was performend and there are more than 0 totalResults', () => {
+  it('renders results if a search was performed and there are more than 0 totalResults', () => {
     setMockSearchContextState({
       ...searchState,
       wasSearched: true,
@@ -100,6 +100,7 @@ describe('SearchExperienceContent', () => {
         totalResults: 0,
       });
     });
+
     it('renders a no documents message', () => {
       const wrapper = shallow(<SearchExperienceContent />);
       expect(wrapper.find('[data-test-subj="documentsSearchResults"]').length).toBe(0);

diff --git a/...lications/app_search/components/documents/search_experience/search_experience_content.tsx b/...lications/app_search/components/documents/search_experience/search_experience_content.tsx
@@ -42,7 +42,7 @@ const DocumentationLink: React.FC = () => (
     href={`${DOCS_PREFIX}/indexing-documents-guide.html`}
   >
     {i18n.translate('xpack.enterpriseSearch.appSearch.documents.search.indexingGuide', {
-      defaultMessage: 'Read the Indexing Guide',
+      defaultMessage: 'Read the indexing guide',
     })}
   </EuiButton>
 );
@@ -53,9 +53,7 @@ export const SearchExperienceContent: React.FC = () => {
   const { myRole } = useValues(AppLogic);
   const { engineName, isMetaEngine } = useValues(EngineLogic);
 
-  if (!wasSearched) {
-    return null;
-  }
+  if (!wasSearched) return null;
 
   if (totalResults) {
     return (