[Security Solution][Notes] - add note block to alert and event detail…

… flyout header
elastic · Sep 19, 2024 · 3a747e0 · 3a747e0
1 parent 7473a0e
commit 3a747e0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/test_ids.ts b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/test_ids.ts
@@ -37,7 +37,7 @@ export const NOTES_TITLE_TEST_ID = `${FLYOUT_HEADER_TEST_ID}NotesTitle` as const
 export const NOTES_COUNT_TEST_ID = `${FLYOUT_HEADER_TEST_ID}NotesCount` as const;
 export const NOTES_LOADING_TEST_ID = `${FLYOUT_HEADER_TEST_ID}NotesLoading` as const;
 
-export const ASSIGNEES_EMPTY_TEST_ID = `${FLYOUT_HEADER_TEST_ID}AssigneesEmtpy` as const;
+export const ASSIGNEES_EMPTY_TEST_ID = `${FLYOUT_HEADER_TEST_ID}AssigneesEmpty` as const;
 export const ASSIGNEES_TEST_ID = `${FLYOUT_HEADER_TEST_ID}Assignees` as const;
 export const ASSIGNEES_TITLE_TEST_ID = `${FLYOUT_HEADER_TEST_ID}AssigneesTitle` as const;
 export const ASSIGNEES_ADD_BUTTON_TEST_ID = `${FLYOUT_HEADER_TEST_ID}AssigneesAddButton` as const;

diff --git a/...press/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_right_panel.cy.ts b/...press/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_right_panel.cy.ts
@@ -41,7 +41,6 @@ import {
   DOCUMENT_DETAILS_FLYOUT_OVERVIEW_TAB,
   DOCUMENT_DETAILS_FLYOUT_TABLE_TAB,
   DOCUMENT_DETAILS_FLYOUT_FOOTER_ISOLATE_HOST,
-  DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_TITLE,
   DOCUMENT_DETAILS_FLYOUT_HEADER_NOTES_TITLE,
   DOCUMENT_DETAILS_FLYOUT_HEADER_NOTES_VALUE,
 } from '../../../../screens/expandable_flyout/alert_details_right_panel';
@@ -95,7 +94,8 @@ describe('Alert details expandable flyout right panel', { tags: ['@ess', '@serve
       .should('be.visible')
       .and('have.text', rule.risk_score);
 
-    cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_TITLE).should('have.text', 'Assignees');
+    // TODO uncomment when the securitySolutionNotesEnabled feature flag is removed
+    // cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_TITLE).should('have.text', 'Assignees');
 
     cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_NOTES_TITLE).should('have.text', 'Notes');
     cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_NOTES_VALUE).should('have.text', '0');

diff --git a/.../security_solution_cypress/cypress/screens/expandable_flyout/alert_details_right_panel.ts b/.../security_solution_cypress/cypress/screens/expandable_flyout/alert_details_right_panel.ts
@@ -51,6 +51,9 @@ export const DOCUMENT_DETAILS_FLYOUT_HEADER_SEVERITY_VALUE = getDataTestSubjectS
 export const DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_TITLE = getDataTestSubjectSelector(
   'securitySolutionFlyoutHeaderAssigneesTitle'
 );
+export const DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_VALUE = getDataTestSubjectSelector(
+  'securitySolutionFlyoutHeaderAssignees'
+);
 export const DOCUMENT_DETAILS_FLYOUT_HEADER_NOTES_TITLE = getDataTestSubjectSelector(
   'securitySolutionFlyoutHeaderAssigneesTitle'
 );

diff --git a/x-pack/test/security_solution_cypress/cypress/tasks/alert_assignments.ts b/x-pack/test/security_solution_cypress/cypress/tasks/alert_assignments.ts
@@ -27,7 +27,7 @@ import {
   ALERT_ASSIGNEES_SELECTABLE_OPTIONS,
 } from '../screens/alerts';
 import { PAGE_TITLE } from '../screens/common/page';
-import { DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES } from '../screens/expandable_flyout/alert_details_right_panel';
+import { DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_VALUE } from '../screens/expandable_flyout/alert_details_right_panel';
 import { expandFirstAlertActions, selectFirstPageAlerts } from './alerts';
 import { login } from './login';
 import { visitWithTimeRange } from './navigation';
@@ -85,7 +85,7 @@ export const checkEmptyAssigneesStateInAlertsTable = () => {
 };
 
 export const checkEmptyAssigneesStateInAlertDetailsFlyout = () => {
-  cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES).within(() => {
+  cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_VALUE).within(() => {
     cy.get(ALERT_AVATARS_PANEL).children().should('have.length', 0);
   });
 };
@@ -137,13 +137,13 @@ export const alertsTableShowsAssigneesBadgeForFirstAlert = (users: string[]) =>
 };
 
 export const alertDetailsFlyoutShowsAssignees = (users: string[]) => {
-  cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES).within(() => {
+  cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_VALUE).within(() => {
     users.forEach((user) => cy.get(`.euiAvatar${ALERT_USER_AVATAR(user)}`).should('exist'));
   });
 };
 
 export const alertDetailsFlyoutShowsAssigneesBadge = (users: string[]) => {
-  cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES).within(() => {
+  cy.get(DOCUMENT_DETAILS_FLYOUT_HEADER_ASSIGNEES_VALUE).within(() => {
     cy.get(ALERT_ASSIGNEES_COUNT_BADGE).contains(users.length);
     users.forEach((user) => cy.get(`.euiAvatar${ALERT_USER_AVATAR(user)}`).should('not.exist'));
   });