Skip to content

Commit

Permalink
Bumping EUI to version 64.0.4 (#140323)
Browse files Browse the repository at this point in the history
* Bumping EUI to version 64.0.1.

* Updating snapshot tests for two directories.

* Deprecate basic usages of getBreakpoint

- in favor of useCurrentEuiBreakpoint

* [Fleet] Deprecate isWithinMaxBreakpoint

- in favor of hook

* [DataViz] Update DataVisualizerTable to use window breakpoint vs table resize observer

- since getBreakpoint is now deprecated, we're only looking at the current EUI breakpoint (based off window width)

* [KibanaThemeProvider] Allow apps to modify the default EUI theme

- Setup for custom xl+ breakpoint sizes used by APM and Synthetics

* [APM] Update useBreakpoints hook with EUI breakpoint deprecations

- since getBreakpoint is no longer an usable util

- EUI's new breakpoint hooks already use/debounce window resize events, so we now get to skip all that custom logic by simply making custom EUI breakpoint overrides and using EUI breakpoint hooks

- remove returned `breakpoint` and `width` keys - they weren't actually being used anywhere in APM that I could see and were causing type errors.
- If someone wants to access them, they can use `useCurrentEuiBreakpoint` and `useWindowSize` individually instead

* [UX] Update useBreakpoints hook copied from APM

- basically the exact same logic, they just also need the xxl and xxxl breakpoints

* [Synthetics] Remove `useBreakpoints` in favor of new EUI breakpoint hooks

+ add xxl and xxxl breakpoints to Synthetics EUI themes

- `useBreakpoints`: - as far as I can tell, all attached APIs are basically the same APIs that EUI provides OOTB:
  - up -> `useIsWithinMinBreakpoint`
  - down -> `useIsWithinMaxBreakpoint`
  - between -> `useIsWithinBreakpoints`
  - debouncedWidth - not used, but could just use `useWindowSize` directly instead

- note: i'm confused by the `xl` override/conflation with `xxl`, but left the default xl breakpoint size as-is and assumed that all usage instances of 'xl' actually wanted 'xxl'

* v64.0.2 - add missing backports and several new fixes

* v64.0.3

* Fix type error from breakpoint deprecation

- functionally doesn't matter since the array doesn't include undefined, so basically just silence TS complaining about it

* Updating additional snapshots after bump to EUI 64.0.3

* Adding RUM Jest snapshot update.

* Adding Timeout to Fleet token generation test.

* Revert "[DataViz] Update DataVisualizerTable to use window breakpoint vs table resize observer"

This reverts commit 4e60ce2.

* [DataViz] Remove getBreakpoint usage

- by replacing the breakpoint logic/switch with custom breakpoint sizes and names

- since the table size can be within panels that don't match `window.innerWidth`, we can't use EUI's breakpoint utils here

* Restoring a needed hook for breakpoints.

* Fix broken side navs on uptime/apm/ux/synthetics

- because of their new custom xxl/xxxl breakpoints, the `isLargerBreakpoint` logic was broken on the shared solution nav. switching to a min breakpoint bound fixes the issue and futureproofs the solution nav for all apps that add larger breakpoints than xl

* Fix snapshots/unit tests from previous commits

* Bumping EUI to 64.0.4 backport.

* [PR feedback] Separate DataVisualizerTable more clearly from EUI breakpoints

- per discussion with Quynh and Walter, there's some confusion around the breakpoints that the table is using. Since the table is width is not always the width of the browser window, it cannot use EUI's breakpoint hooks, and should instead use its own custom map of table-specific breakpoints to make that separation clearer

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
3 people committed Sep 20, 2022
1 parent 7026b57 commit 3788293
Show file tree
Hide file tree
Showing 39 changed files with 814 additions and 577 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.3.0-canary.1",
"@elastic/ems-client": "8.3.3",
"@elastic/eui": "63.0.6",
"@elastic/eui": "64.0.4",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
Loading

0 comments on commit 3788293

Please sign in to comment.