Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][IIS] Migrate Access and error logs dashboard visualizations to lens in kibana 8.5.0 #5724

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 29, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for IIS integration package

  • Statistics for IIS Lens migration:

IIS dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs IIS] Access and error logs 0 5 5 0
  0 5 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

Note: Below panel which contains split chart functionality has been migrated to table visualization.
Before Migration:
screencapture-storage-0-kb-us-central1-gcp-cloud-es-io-9243-app-dashboards-2023-03-24-12_29_30

After Migration:
kibana-iis

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 29, 2023 05:09
@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T04:19:03.334+0000

  • Duration: 14 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35)
Lines 93.772% (271/289)
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 29, 2023
9 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:iis IIS v8.5.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 29, 2023
@kush-elastic kush-elastic self-requested a review March 30, 2023 08:23
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

@SubhrataK , are you good with the split chart functionality has been migrated to table visualization. (screenshot shared above).

@rajvi-patel-22
Copy link
Contributor Author

@agithomas, As per the discussion, the below panel with split chart functionality will be migrated to horizontal bar chart.
Please find below screenshots:

Before Migration
image (17)

After Migration
image (18)

CC: @SubhrataK

@rajvi-patel-22
Copy link
Contributor Author

@agithomas, As per the discussion, the below panel with split chart functionality will be migrated to horizontal bar chart. Please find below screenshots:

Before Migration image (17)

After Migration image (18)

CC: @SubhrataK

@agithomas, I have updated the PR with mentioned changes.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:iis IIS Team:Service-Integrations Label for the Service Integrations team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants