This repository has been archived by the owner on May 16, 2023. It is now read-only.
[logstash] use only httpPort in headless service #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix an issue introduced in 8ed75a9 where helm install/upgrade is failing if a NodePort service is defined (see [0] for more details). Logstash headless service used to manage Statefulset does not anymore include `.Values.service.ports` and include only Logstash httpPort. This is done because headless service `ports` doesn't accept `nodePort` values that can be included in `.Values.service.ports` when adding a NodePort service. [0]: elastic#807
jmlrt
force-pushed
the
logstash-svc-807
branch
from
b677ca4
to
c562335
Compare
jmlrt
added a commit
that referenced
this pull request
Oct 16, 2020
This commit fix an issue introduced in 8ed75a9 where helm install/upgrade is failing if a NodePort service is defined (see [0] for more details). Logstash headless service used to manage Statefulset does not anymore include `.Values.service.ports` and include only Logstash httpPort. This is done because headless service `ports` doesn't accept `nodePort` values that can be included in `.Values.service.ports` when adding a NodePort service. [0]: #807
jmlrt
added a commit
that referenced
this pull request
Oct 16, 2020
This commit fix an issue introduced in 8ed75a9 where helm install/upgrade is failing if a NodePort service is defined (see [0] for more details). Logstash headless service used to manage Statefulset does not anymore include `.Values.service.ports` and include only Logstash httpPort. This is done because headless service `ports` doesn't accept `nodePort` values that can be included in `.Values.service.ports` when adding a NodePort service. [0]: #807
jmlrt
added a commit
that referenced
this pull request
Oct 16, 2020
This commit fix an issue introduced in 8ed75a9 where helm install/upgrade is failing if a NodePort service is defined (see [0] for more details). Logstash headless service used to manage Statefulset does not anymore include `.Values.service.ports` and include only Logstash httpPort. This is done because headless service `ports` doesn't accept `nodePort` values that can be included in `.Values.service.ports` when adding a NodePort service. [0]: #807
|
backported to |
Closed
This was referenced Oct 21, 2020
Closed
Merged
Closed
This was referenced Nov 16, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This was referenced Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix an issue introduced in 8ed75a9 where helm
install/upgrade is failing if a NodePort service is defined.
Logstash headless service used to manage Statefulset does not anymore include
.Values.service.portsand include only Logstash httpPort.This is done because headless service
portsdoesn't acceptnodePortvalues that can be included in
.Values.service.portswhen adding aNodePort service.
Fix #807