Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] fix secrets names in examples #811

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Sep 16, 2020

Kubernetes doesn't accept _ characters in resources names.
This commit fix the secrets names in the examples we provide by
replacing _ by -which Kubernetes is accepting.

Source: helm/helm#6477

Fixes #747

Kubernetes doesn't accept `_` characters in resources names.
This commit fix the secrets names in the examples we provide by
replacing `_` by `-`which Kubernetes is accepting.

Source: helm/helm#6477
@jmlrt jmlrt added bug Something isn't working docs labels Sep 16, 2020
@jmlrt jmlrt requested a review from a team September 16, 2020 08:09
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit 385f8d3 into elastic:master Sep 16, 2020
@jmlrt jmlrt deleted the fix-secret-examples branch September 16, 2020 16:25
jmlrt added a commit that referenced this pull request Sep 16, 2020
Kubernetes doesn't accept `_` characters in resources names.
This commit fix the secrets names in the examples we provide by
replacing `_` by `-`which Kubernetes is accepting.

Source: helm/helm#6477
jmlrt added a commit that referenced this pull request Sep 16, 2020
Kubernetes doesn't accept `_` characters in resources names.
This commit fix the secrets names in the examples we provide by
replacing `_` by `-`which Kubernetes is accepting.

Source: helm/helm#6477
jmlrt added a commit that referenced this pull request Sep 16, 2020
Kubernetes doesn't accept `_` characters in resources names.
This commit fix the secrets names in the examples we provide by
replacing `_` by `-`which Kubernetes is accepting.

Source: helm/helm#6477
@nkammah nkammah mentioned this pull request Sep 24, 2020
@nkammah nkammah mentioned this pull request Oct 19, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Secret "slack_hook" is invalid: metadata.name
2 participants