Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] String/YAML conditions for .Values.{extraContainers,extraInitContainers} #637

Merged
merged 1 commit into from
May 27, 2020

Conversation

maxkochubey
Copy link
Contributor

...which are just copied from Elasticsearch helmchart.

Resolves #636.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented May 20, 2020

💚 CLA has been signed

@mitchellmaler
Copy link

@maxkochubey Can this be added to the filebeat and metricbeat charts as well?
All have the extraContainers but it is not yml and using tpl. I also wonder if this should be a new variables like extraContainersYaml that way it doesn't break existing.

@jmlrt
Copy link
Member

jmlrt commented May 27, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented May 27, 2020

cla/check

@jmlrt jmlrt added bug Something isn't working kibana labels May 27, 2020
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt merged commit 17ab273 into elastic:master May 27, 2020
jmlrt pushed a commit that referenced this pull request May 27, 2020
jmlrt pushed a commit that referenced this pull request May 27, 2020
jmlrt pushed a commit that referenced this pull request May 27, 2020
@jmlrt
Copy link
Member

jmlrt commented May 27, 2020

backported to 6.8 branch in ef9aaa5
backported to 7.x branch in ba03954
backported to 7.7 branch in 669e799

jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request May 27, 2020
This was referenced Jun 3, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working kibana v6.8.10 v7.7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kibana] extraInitContainers and extraContainers as YAMLs
4 participants