Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Added support for envFrom in apm-server, logstash, kibana and elasticsearch #569

Merged
merged 5 commits into from
Apr 23, 2020

Conversation

cartonalexandre
Copy link
Contributor

@cartonalexandre cartonalexandre commented Apr 8, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

I think integration tests are difficult to add because of this feature use secret or configMap from kubernetes.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cartonalexandre cartonalexandre changed the title Add support to envFrom for apm-server, logstash, kibana and elasticsearch Added support for envFrom in apm-server, logstash, kibana and elasticsearch Apr 8, 2020
@jmlrt jmlrt added the enhancement New feature or request label Apr 10, 2020
@jmlrt
Copy link
Member

jmlrt commented Apr 20, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cartonalexandre, thanks for this PR.
Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/143.

@jmlrt
Copy link
Member

jmlrt commented Apr 22, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Apr 22, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴
Thanks for this PR 👍

@jmlrt jmlrt merged commit 35e0509 into elastic:master Apr 23, 2020
@jmlrt jmlrt added the v7.7.0 label Apr 23, 2020
jmlrt added a commit that referenced this pull request Apr 23, 2020
Added support for envFrom in apm-server, logstash, kibana and elasticsearch
@jmlrt
Copy link
Member

jmlrt commented Apr 23, 2020

backported to 7.7 branch in e2d4b9c

@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants