This repository has been archived by the owner on May 16, 2023. It is now read-only.
Add extensible label support on Kibana #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
ramrodo
force-pushed
the
kibana-extensible-labels
branch
from
f9103b3
to
ad21c81
Compare
|
jenkins test this please |
Common labels were moved to helpers template to have only one source of truth of common/added labels shared between all Kibana resources. Also, this extends the capability to add a custom label and this will be common between all the resources.
ramrodo
force-pushed
the
kibana-extensible-labels
branch
from
ad21c81
to
753a677
Compare
|
I did a rebase because there were conflicts with the |
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
jmlrt
pushed a commit
that referenced
this pull request
May 29, 2020
Common labels were moved to helpers template to have only one source of truth of common/added labels shared between all Kibana resources. Also, this extends the capability to add a custom label and this will be common between all the resources.
jmlrt
pushed a commit
that referenced
this pull request
May 29, 2020
Common labels were moved to helpers template to have only one source of truth of common/added labels shared between all Kibana resources. Also, this extends the capability to add a custom label and this will be common between all the resources.
jmlrt
pushed a commit
that referenced
this pull request
May 29, 2020
Common labels were moved to helpers template to have only one source of truth of common/added labels shared between all Kibana resources. Also, this extends the capability to add a custom label and this will be common between all the resources.
|
backported to |
3 tasks
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common labels were moved to helpers template to have only one source of truth of common/added labels shared between all Kibana resources.
Also, this extends the capability to add a custom label and this will be common between all the resources.
This is useful in many ways because it allows querying all the Kibana resources that match a common label and be used in a whole service backup with other resources outside of its chart's responsibility.
Updated template tests in${CHART}/tests/*.pyUpdated integration tests in${CHART}/examples/*/test/goss.yaml