This repository has been archived by the owner on May 16, 2023. It is now read-only.
[apm-server]Fix fullnameOverride setting #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
jmlrt
suggested changes
Mar 6, 2020
There was a problem hiding this comment.
black formatter requires that variables are surrounding by double quotes instead of single quotes. The rest LGTM 👍
|
jenkins test this please |
jmlrt
suggested changes
Mar 6, 2020
apm-server/tests/apmserver_test.py
Outdated
| "name" | ||
| ] | ||
| == project | ||
| ) |
There was a problem hiding this comment.
I think black is now complaining about the missing newline :(
|
jenkins test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml