Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[helm] bump helm version to 2.15.1 #338

Merged
merged 5 commits into from
Oct 23, 2019
Merged

[helm] bump helm version to 2.15.1 #338

merged 5 commits into from
Oct 23, 2019

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Oct 21, 2019

does what it says in the tin

Had to bump directly to v2.15.1 which contain an emergency fix we need in our test scripts (helm/helm#6722).

@jmlrt jmlrt added the enhancement New feature or request label Oct 21, 2019
@jmlrt jmlrt self-assigned this Oct 21, 2019
@jmlrt
Copy link
Member Author

jmlrt commented Oct 21, 2019

Elasticsearch chart lint is failing with Helm 2.15.0:

10:22:33 helm lint --strict ./
10:22:33 Error: 1 chart(s) linted, 1 chart(s) failed
10:22:33 ==> Linting ./
10:22:33 [ERROR] Chart.yaml: apiVersion is required
10:22:33 [ERROR] templates/: render error in "elasticsearch/templates/service.yaml": template: elasticsearch/templates/service.yaml:24:14: executing "elasticsearch/templates/service.yaml" at <.Values.service.nodePort>: map has no entry for key "nodePort"

elastic+helm-charts+pull-request+template-testing/227/CHART=elasticsearch

This is required witrh Helm 2.15.0 following helm/helm#6180
This fix the following errors during `helm lint --strict`:
```
==> Linting .
[ERROR] templates/: render error in "elasticsearch/templates/service.yaml": template: elasticsearch/templates/service.yaml:24:14: executing "elasticsearch/templates/service.yaml" at <.Values.service.nodePort>: map has no entry for key "nodePort"
```
@jmlrt jmlrt requested a review from Crazybus October 22, 2019 16:27
@jmlrt
Copy link
Member Author

jmlrt commented Oct 22, 2019

jenkins test this please

This fix a bug on helm upgrade (helm/helm#6718)
@jmlrt jmlrt changed the title [helm] bump helm version to 2.15.0 [helm] bump helm version to 2.15.1 Oct 23, 2019
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmlrt jmlrt merged commit 6eb124e into elastic:master Oct 23, 2019
@jmlrt jmlrt deleted the helm-2-15 branch October 23, 2019 12:08
@Conky5 Conky5 mentioned this pull request Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants