Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Had to add a couple extra mounts to get MetricBeat to pick up all the… #314

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

pbecotte
Copy link
Contributor

@pbecotte pbecotte commented Oct 5, 2019

… metrics from the host nodes on Digital Ocean. In the process, noticed that the extraMount setting is configured different then the rest- changed it to be consistent. Not being a metricbeat expert, it is possible there was a better way to do this?

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

… metrics from the host nodes on Digital Ocean. In the process, noticed that the extraMount setting is configured different then the rest- changed it to be consistent
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mikehodgk
Copy link

spent a few hours trying to work out why my extra mounts weren't working! Thanks for this. Would be great to see it merged.

@jmlrt
Copy link
Member

jmlrt commented Oct 10, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this PR

@jmlrt jmlrt added the enhancement New feature or request label Oct 10, 2019
@jmlrt jmlrt merged commit 7e74e7c into elastic:master Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants