Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Make it possible to override the endpoint template. #298

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Make it possible to override the endpoint template. #298

merged 1 commit into from
Sep 23, 2019

Conversation

floretan
Copy link
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

We would like to use the elasticsearch chart as a subchart, where the name of the resource needs to match the release name (the common structure used by many charts, like the official mariadb chart).

This was quite easy to do by overriding the helm template for uname and masterService (replacing their content with {{ .Release.Name }}-elasticsearch), but the endpoints template also needs to be overridden, and due to the way parameters are passed the trick above doesn't work.

This change simply passes moves the specification of .Values to the helm template, enabling overrides to access top-level parameters like .Release.Name. The behavior stays unchanged. This template is also not used anywhere else.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Contributor

I have no idea why I did this, it doesn't make any sense :P Thank you for finding and fixing the issue!

jenkins test this please

@Crazybus Crazybus merged commit 21b711a into elastic:master Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants