Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

ES Variable Port Name #270

Merged
merged 3 commits into from
Sep 19, 2019
Merged

ES Variable Port Name #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10ac225
ES Variable Port Name
GreenKnight15 Sep 3, 2019
9e0ddbb
Merge branch 'master' into es-variable-port-name
Crazybus Sep 18, 2019
8dc44dd
Update values file and added templates to both services
GreenKnight15 Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions elasticsearch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ helm install --name elasticsearch elastic/elasticsearch --set imageTag=7.3.0
| `service.type` | Type of elasticsearch service. [Service Types](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) | `ClusterIP` |
| `service.nodePort` | Custom [nodePort](https://kubernetes.io/docs/concepts/services-networking/service/#nodeport) port that can be set if you are using `service.type: nodePort`. | `` |
| `service.annotations` | Annotations that Kubernetes will use for the service. This will configure load balancer if `service.type` is `LoadBalancer` [Annotations](https://kubernetes.io/docs/concepts/services-networking/service/#ssl-support-on-aws) | `{}` |
| `service.httpPortName` | The name of the http port within the service | `http` |
| `service.transportPortName` | The name of the transport port within the service | `transport` |
| `updateStrategy` | The [updateStrategy](https://kubernetes.io/docs/tutorials/stateful-application/basic-stateful-set/#updating-statefulsets) for the statefulset. By default Kubernetes will wait for the cluster to be green after upgrading each pod. Setting this to `OnDelete` will allow you to manually delete each pod during upgrades | `RollingUpdate` |
| `maxUnavailable` | The [maxUnavailable](https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget) value for the pod disruption budget. By default this will prevent Kubernetes from having more than 1 unhealthy pod in the node group | `1` |
| `fsGroup (DEPRECATED)` | The Group ID (GID) for [securityContext.fsGroup](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) so that the Elasticsearch user can read from the persistent volume | `` |
Expand Down
8 changes: 4 additions & 4 deletions elasticsearch/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ spec:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
app: "{{ template "uname" . }}"
ports:
- name: http
- name: {{ .Values.service.httpPortName | default "http" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaults can be removed from here now that you have added the defaults into the values.yaml.

Suggested change
- name: {{ .Values.service.httpPortName | default "http" }}
- name: {{ .Values.service.httpPortName }}

protocol: TCP
port: {{ .Values.httpPort }}
{{- if .Values.service.nodePort }}
nodePort: {{ .Values.service.nodePort }}
{{- end }}
- name: transport
- name: {{ .Values.service.transportPortName | default "transport" }}
protocol: TCP
port: {{ .Values.transportPort }}
---
Expand All @@ -46,7 +46,7 @@ spec:
selector:
app: "{{ template "uname" . }}"
ports:
- name: http
- name: {{ .Values.service.httpPortName | default "http" }}
port: {{ .Values.httpPort }}
- name: transport
- name: {{ .Values.service.transportPortName | default "transport" }}
port: {{ .Values.transportPort }}
2 changes: 2 additions & 0 deletions elasticsearch/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ service:
type: ClusterIP
nodePort:
annotations: {}
httpPortName: http
transportPortName: transport

updateStrategy: RollingUpdate

Expand Down