Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] Fix default configuration for kubernetes module #251

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Aug 9, 2019

This configuration didn't work at all since the nodes localhost is not
reachable from the kubernetes pod. The test has also been fixed up to
make sure that the data coming in actually has proper fields in it. The
test was passing because the events were coming in but just with errors.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

This configuration didn't work at all since the nodes localhost is not
reachable from the kubernetes pod. The test has also been fixed up to
make sure that the data coming in actually has proper fields in it. The
test was passing because the events were coming in but just with errors.
@Crazybus Crazybus requested a review from tylerjl August 9, 2019 11:29
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Crazybus Crazybus merged commit 8f9999d into master Aug 12, 2019
@Crazybus Crazybus deleted the fielding_lucky branch August 12, 2019 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants