Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Update documentation and defaults for tmpl values #238

Merged
merged 1 commit into from
Aug 2, 2019
Merged

[elasticsearch] Update documentation and defaults for tmpl values #238

merged 1 commit into from
Aug 2, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jul 30, 2019 •
edited
Loading

Closes: #235

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@Crazybus Crazybus requested a review from tylerjl July 30, 2019 10:54
@Crazybus Crazybus mentioned this pull request Jul 30, 2019
Closed
tylerjl
tylerjl previously approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other charts like Filebeat need this change as well? I noted that the original report was for Filebeat and Filebeat chart has default values of empty arrays as well [].

@Crazybus Crazybus force-pushed the template_temple branch 2 times, most recently from 79d1a66 to c0ca407 Compare August 1, 2019 09:01
@Crazybus Crazybus requested a review from tylerjl August 1, 2019 09:05
@Crazybus
Copy link
Contributor Author

Crazybus commented Aug 1, 2019

Do the other charts like Filebeat need this change as well? I noted that the original report was for Filebeat and Filebeat chart has default values of empty arrays as well [].

Absolutely yes. Thank you for catching this, I have updated the PR with the changes for metricbeat and filebeat (not implemented in Kibana). PTAL!

tylerjl
tylerjl approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit: 🚗

@Crazybus Crazybus merged commit 24ac48a into master Aug 2, 2019
@Crazybus Crazybus deleted the template_temple branch August 2, 2019 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tylerjl tylerjl tylerjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filebeat: wrong type for value, extraVolumes/extraVolumeMounts
2 participants
@Crazybus @tylerjl