Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Add option to provide custom start/stop hooks #197

Merged
merged 7 commits into from
Jul 5, 2019

Conversation

tetianakravchenko
Copy link

@tetianakravchenko tetianakravchenko commented Jul 2, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

PR should fix issue: #190

Tetiana Kravchenko added 3 commits July 2, 2019 11:01
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
elasticsearch/values.yaml Outdated Show resolved Hide resolved
Tetiana Kravchenko added 4 commits July 3, 2019 11:15
…dd sugested test

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks perfect ⭐️

@Crazybus
Copy link
Contributor

Crazybus commented Jul 5, 2019

jenkins test this please

@tetianakravchenko
Copy link
Author

tetianakravchenko commented Jul 5, 2019

@Crazybus there is some issue on k8s 1.13, not related to the PR :

11:10:30 Error: Nothing to do
11:10:31 The command '/bin/sh -c yum -y install     https://packages.cloud.google.com/yum/pool/654962a43cb6bc6b47bc312424410b7c203e1beb73386d868d9e614839c82609-google-cloud-sdk-215.0.0-1.el7.noarch.rpm &&     gcloud config set core/disable_usage_reporting true &&     gcloud config set component_manager/disable_update_check true &&     gcloud version' returned a non-zero code: 1
11:10:46 Unable to find image 'helm-charts:latest' locally
11:10:46 docker: Error response from daemon: pull access denied for helm-charts, repository does not exist or may require 'docker login'.```

@Crazybus
Copy link
Contributor

Crazybus commented Jul 5, 2019

None of your changes should be affecting the integration tests. The template testing passed though so good enough https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+template-testing/73/. I'll look into the flakiness of the other tests but that's unrelated to your changes.

Thank you again for adding this in!

@Crazybus Crazybus merged commit e1dbc59 into elastic:master Jul 5, 2019
@tetianakravchenko
Copy link
Author

@Crazybus any updates on when those changes will be released?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants