Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fix octal literal to work in both Python 2 and Python 3 #188

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 26, 2019

$ python3 -c "0600"

  File "<string>", line 1
    0600
       ^
SyntaxError: invalid token
  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

$ __python3 -c "0600"__
```
  File "<string>", line 1
    0600
       ^
SyntaxError: invalid token
```
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Out of interest, does this mean that the rest of the testing all "just works" with python3?

@Crazybus
Copy link
Contributor

Crazybus commented Jul 1, 2019

jenkins test this please

@Crazybus
Copy link
Contributor

Crazybus commented Jul 1, 2019

@cclauss This is ready to be merged, but it looks like you haven't yet signed the CLA

@cclauss
Copy link
Contributor Author

cclauss commented Jul 1, 2019

I have signed it twice. Is there a way to debug the CLA process?

@Crazybus
Copy link
Contributor

Crazybus commented Jul 1, 2019

I have signed it twice. Is there a way to debug the CLA process?

Looks like its working now! Thanks!

@Crazybus Crazybus merged commit db58550 into elastic:master Jul 1, 2019
@cclauss cclauss deleted the patch-1 branch July 1, 2019 09:15
cclauss added a commit to cclauss/helm-charts that referenced this pull request Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants