Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

fix support wildcard tls host on ingress #184

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

diegofernandes
Copy link
Contributor

@diegofernandes diegofernandes commented Jun 21, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice find! It seems like the value just needed to be quoted properly, however I think your approach is much much cleaner.

FYI this is what comes from the helm create template so its very possible that this needs to be fixed upstream too in the helm repo.

@Crazybus
Copy link
Contributor

jenkins test this please

@diegofernandes
Copy link
Contributor Author

@Crazybus I had tried quoted my config, but It's cause an error.

Error: YAML parse error on kibana/templates/ingress.yaml: error converting YAML to JSON: yaml: line 16: did not find expected alphabetic or numeric character
Error: UPGRADE FAILED: YAML parse error on kibana/templates/ingress.yaml: error converting YAML to JSON: yaml: line 16: did not find expected alphabetic or numeric character

@Crazybus Crazybus merged commit 80845fc into elastic:master Jun 24, 2019
@Crazybus
Copy link
Contributor

Thank you again for finding and fixing this!

@Crazybus I had tried quoted my config, but It's cause an error.

Yeah in the config didn't work, I meant quoting it inside the template. Your solution is much cleaner though 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants