Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Always run tests against localhost or the service endpoint #181

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

Crazybus
Copy link
Contributor

This makes sure that:

  1. The tests work in ipv4 and ipv6 environments
  2. Testing the service endpoint makes sure that the listening address is
    properly configured to allow traffic

Addresses: #169 (review)

This makes sure that:

1. The tests work in ipv4 and ipv6 environments
2. Testing the service endpoint makes sure that the listening address is
properly configured to allow traffic

Addresses: #169 (review)
@Crazybus Crazybus requested a review from tylerjl June 21, 2019 07:17
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ this is what I was getting at in my previous PR comment, LGTM

@Crazybus Crazybus merged commit e27d753 into master Jun 24, 2019
@Crazybus Crazybus deleted the ipv6_is_the_future branch June 24, 2019 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants